New module to handle firstboot detection in the initrd #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laenion
reviewed
Aug 8, 2023
Horrible? I think it turned out fine actually... |
Vogtinator
force-pushed
the
firstbootdetect
branch
3 times, most recently
from
3914972
to
59d3cc7
Compare
Vogtinator
force-pushed
the
firstbootdetect
branch
3 times, most recently
from
9aa0711
to
624b553
Compare
Vogtinator
changed the title
Vogtinator
force-pushed
the
firstbootdetect
branch
2 times, most recently
from
fb008f2
to
160d767
Compare
Look at /etc/machine-id in the /sysroot, similar to what ConditionFirstBoot in the real root would do. If firstboot is detected, start firstboot.target.
If the initrd is hostonly and /etc/machine-id already exists, don't include the combustion dracut module and its dependencies.
Previously this was done by the ignition.firstboot handling code in grub.cfg.
Ignition meanwhile uses ignition-umount-initrd-fstab.service instead.
If firstboot was triggered by presence of the reconfig_system marker, ignition-kargs-helper's call to combustion removes the marker and after the reboot the other firstboot stages would not run. Only remove the marker if it was an actual combustion run.
Vogtinator
force-pushed
the
firstbootdetect
branch
from
160d767
to
27fb600
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Look at /etc/machine-id in the /sysroot, similar to what ConditionFirstBoot in
the real root would do. If firstboot is detected, start firstboot.target.
TODO:
x-initrd.mounthandling intofirstboot-detect