Missing error message when ditaa is not installed

[tomschr]

Problem description

Assume, the ditaa command is NOT installed, you get the following output when you try to build a document in doc-modular:

$ cd doc-modular
$ daps -v -d DC-concept-time-synchronization-ntp html
make: *** [/usr/share/daps/make/images.mk:470: /home/toms/repos/GH/SUSE/doc-modular/build/.images/gen/png/desktop-machine-ntp.png] Error 127
make: *** Waiting for unfinished jobs....
make: *** [/usr/share/daps/make/images.mk:470: /home/toms/repos/GH/SUSE/doc-modular/build/.images/gen/png/multiple-machines-ntp.png] Error 127

It's a weird error message and it has nothing to do with the real problem.

If you change -v to -vv you get:

daps output with -vv option

$ daps -vv -d DC-concept-time-synchronization-ntp html
---------------

        DAPS VERSION: 3.2.0

             DOC_DIR: /home/toms/repos/GH/SUSE/doc-modular
           BUILD_DIR: /home/toms/repos/GH/SUSE/doc-modular/build
            DAPSROOT: /usr/share/daps
             DOCCONF: /home/toms/repos/GH/SUSE/doc-modular/DC-concept-time-synchronization-ntp
                BOOK: concept-time-synchronization-ntp

           PROFILING: On
       PROFCONDITION: suse-product

     DOCBOOK_VERSION: 5
        DOCBOOK5_RNG: /usr/share/xml/docbook/schema/rng/5.1/docbookxi.rng
        DBSTYLE_VERS: snapshot

           STYLEROOT: /usr/share/xml/docbook/stylesheet/suse2021-ns
      STYLEROOT_VERS: '2.81.0'
  FALLBACK_STYLEROOT: /usr/share/xml/docbook/stylesheet/suse-ns
   FB_STYLEROOT_VERS: '2.81.0'
            EPUB_CSS: 
            HTML_CSS: 

       PDF FORMATTER: fop
   FORMATTER VERSION: FOP Version 2.6
   FORMATTER WRAPPER: /usr/share/daps/libexec/daps-fop
    FORMATTER CONFIG: 

            MAKE_CMD: /usr/bin/make -f /usr/share/daps/make/selector.mk -j6 -s html 
       XSLTPROCESSOR: /usr/bin/xsltproc
   XML_CATALOG_FILES: /etc/xml/catalog

---------------

   Converting desktop-machine-ntp.ditaa to PNG
   Converting multiple-machines-ntp.ditaa to PNG
/bin/bash: ditaa: command not found
make: *** [/usr/share/daps/make/images.mk:469: /home/toms/repos/GH/SUSE/doc-modular/build/.images/gen/png/desktop-machine-ntp.png] Error 127
make: *** Waiting for unfinished jobs....
/bin/bash: ditaa: command not found
make: *** [/usr/share/daps/make/images.mk:469: /home/toms/repos/GH/SUSE/doc-modular/build/.images/gen/png/multiple-machines-ntp.png] Error 127

The difference from the first output is the error message /bin/bash: ditaa: command not found. This is not printed, but IMHO it should.

Expected behavior

As ditaa is currently not a requirement in the RPM package, I fear a lot of writers will fall into this trap.

I'd suggest:

• Add the ditaa package as a recommends or requirements into our package
• Make ditaa package available in Documentation:Tools. Currently, ditaa is only available in some home repos.
• Make error message visible.

Steps to reproduce problem

1. Uninstall ditaa (or rename the command).
2. Run the above command with -v and -vv to see the difference.

[fsundermeyer]

Fixed with 2a51f44