Add download_data_from_download-o-o.sh #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lkocman
commented
Nov 29, 2023
•
lkocman
commented
- Extract translatable files/metadata from download-o-o This is especially useful for layered projects (e.g. Leap >= 15.3), where buildresults of one or more layer do not contain extracted desktopfiles etc (needed by download_data.sh).
- Actual data is submitted in Leap 15.6 desktop-file-translations #14
- Original discussion about issues with newer Leap releases in https://progress.opensuse.org/issues/100023
lkocman
added a commit
to lkocman/desktop-file-translations
that referenced
this pull request
Nov 29, 2023
* Used by experimental 51-xml/download_data_from_download-o-o.sh from Add download_data_from_download-o-o.sh openSUSE#13
lkocman
added a commit
to lkocman/desktop-file-translations
that referenced
this pull request
Nov 29, 2023
* Used by experimental 51-xml/download_data_from_download-o-o.sh from openSUSE#13
Vogtinator
reviewed
Nov 29, 2023
| bzip2 $tgdir/$pkg-desktopfiles.tar | ||
| fi | ||
| fi | ||
| if [ ! -f "$tgdir/$pkg-appstream.tar.bz2" ]; then |
There was a problem hiding this comment.
AFAIK only the desktop file translations are actually used, the others were implemented for some possible future expansion which never happened. You might be able to save quite a bit of time.
lkocman
added a commit
to lkocman/desktop-file-translations
that referenced
this pull request
Nov 30, 2023
* Used by experimental 51-xml/download_data_from_download-o-o.sh from openSUSE#13 * Skipped data from -*appstream.tar.bz and -polkitactions.tar.bz based on agremeent with Fabian
* Extract translatable files/metadata from download-o-o This is especially useful for layered projects (e.g. Leap >= 15.3), where buildresults of one or more layer do not contain extracted desktopfiles etc (needed by download_data.sh). * Actual data is submitted in Leap 15.6 desktop-file-translations openSUSE#14 Original discussion about issues with newer Leap releases in https://progress.opensuse.org/issues/100023
lkocman
force-pushed
the
download-o-o
branch
from
def2f12
to
90d2d1f
Compare
|
Oky "rebased" and commented out fitlers for extraction of polkit and appstream files, that will cut some time. I'll keep the part for handling it, just in case we'd ever need it in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.