changelogtest should be a separate standalone test ( not part of gitarro itself)

[MalloZup]

Figure out how to extrapolate the whole changelog flag and make a standalone test that gitarro will execute like

-t changelog.rb

[MalloZup]

@juliogonzalez i think this --changelogtest option is kind of unrelated and is adding more complexity on the codebase.

The idea is to make a separate script that will be used on a job

[juliogonzalez]

I agree.

We should maybe provide it inside the tools/ directory and then as an example.

[MalloZup]

@juliogonzalez afaik, the simplest solution for this, imho would be to create a docker container from gitarro, and freeze this container with the version of gitarro containing the changelog test.
( where we call changelogtest the whole container and would be just a unsupported tool, and we would have the container somewhere in CI but not here)

I had a look at the changelog tests and this is the simplest solution imho.

[juliogonzalez]

Let me see how the changelog test works right now and think a little about it, before we take a final decission.

[MalloZup]

@juliogonzalez i have found a solution for this:

With this simply extrernal script:

´gitarro -t script´

git ls-tree --name-only -r HEAD^ | grep .changes .. etc

We can test if last commit changed the .changes file or not, which is what we want.

The only issue, is in case a PR doesn't need to modify the changelog.

[juliogonzalez]

I am not 100% sure, but I think it won't work if the PR has several commits and the changelog was not changed at the last commit.

[juliogonzalez]

I will have a look today, but IMHO we would need a simple ruby script to check GitHub API.

Since netrc will be already present, it should be easy to do it.

[MalloZup]

the only difficulty is that from gitarro to the test_script, the test script doesn't know which PR number is tested (gitarro know that), and other info.

If you use another script to use the github api, ( we will consume again rate limiting) :D .

good luck

[juliogonzalez]

Then most probably we need to refactor the changelog test to make the currenct code easier :-D

[MalloZup]

atm the changelogtest is so refactored that it disappear :)

[juliogonzalez]

Then maybe we will need to re-add it :-)