Init changelog isolation tests. #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MalloZup
commented
Oct 18, 2017
| @@ -0,0 +1,51 @@ | |||
| #! /usr/bin/ruby | |||
There was a problem hiding this comment.
@juliogonzalez this is how easy and understable is now the changelog test .
All the trigger logic removed and it is done by the engine.
I am not finish, but this is a great improvement to isolate this test from the engine.
MalloZup
force-pushed
the
isolate_changelog
branch
2 times, most recently
from
b7815fb
to
8cbed52
Compare
Isolate the test a tool script Remove all changelog code from backend,tests, doc New changelog test isolated.
MalloZup
force-pushed
the
isolate_changelog
branch
from
d760131
to
1517dfd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove changelog tests/checks from backend.
What does this PR do?
This pr will remove changelog logic from backend.rb in order to isolate the test and allow refactoring.
What issues does this PR fix or reference?
fix #54
Tests written?
once the test will be isolated, the script will be freezed.