3 small patches to please Debian package maintainers #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 please commit thast patches. hwinfo get horrible builds without that! |
|
updated pr a bit and merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
the following patches do 4 things:
1) fixes spelling errors (really minor patch)
2) updates makefiles to respect outer environmenet variables like $LIBDIR, $CFLAGS, $CPPFLAGS, and $LDFLAGS
3) allows to build hwinfo outside github clone; if HWINFO_VERSION is defined then it is used to provide version number instead of git2log which has to be run inside git repository; also both "VERSION" and "changelog" are added to cleaned files
4) uses pkg-config to supply includes to dbus
Cheers,
Tomasz