ensure /proc is mounted in chroot environments (bsc#1176972) #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glibc and others rely on it.
Closed
jreidinger
reviewed
Oct 5, 2020
|
|
||
| # - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - | ||
| # Set up /proc and /dev/fd in directory dir if they are missing as a number | ||
| # of tools rely on these (bsc#1160594, bsc#1176972). |
There was a problem hiding this comment.
when doing it why not proc mount also "/sys" I think some tools also use it. Otherwise change looks reasonable.
There was a problem hiding this comment.
The main reason here is the secure access to file descriptors via /proc/self. /sys exposes too much of the host system and it would kind of contradict the use of a chroot environment.
Note that using /proc is also not without problems as it already exposes quite a lot and processes might influence the host system in unwanted ways.
It's a compromise already and I would not want to stretch it further.
jreidinger
approved these changes
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
glibc and others rely on
/procto be mounted in chroot environments to function properly.Solution
Temporarily mount
/procif missing. And also set up/dev/fdsymlinks to/proc/self/fd.