Allows the skip of timezone and password dialogs

[aplanas]

Add two new variables to jeos-firstboot:

• TIMEZONE_PRESET
  Based on LOCALE_PRESET and KEYTABLE_PRESET, this new variable will affect the systemd_firstboot_args array if is set, and will skip the time-zone dialog.

• PASSWORD_ALREADY_SET
  If set to a non-zero value, will skip the root password dialog. Is expected that the user is setting the root password via other means, like config.sh or the Kiwi users XML tag.

Also fix the call of btrfs on non-btrfs file systems.

[aplanas]

Added a new commit to fix a bug in the btrfs call

[aplanas]

Already tested for my use case.

[lnussel]

how do you set those variables? Maybe jeos-firstboot needs a config nowadays and branding packages for different use cases.

[aplanas]

@lnussel creating systemd overlays:

#======================================
# Overlay for jeos-firstboot (Yomi)
#--------------------------------------
if [[ "$kiwi_profiles" == *"Live"* ]]; then
	LOCALE="en_US"
	KEYTABLE="jp"
	TIMEZONE="UTC"
	mkdir -p /etc/systemd/system/jeos-firstboot.service.d/
	cat > /etc/systemd/system/jeos-firstboot.service.d/10-presets.conf <<-EOF
		[Service]
		Environment=SYSTEMCTL_OPTIONS=--ignore-dependencies TERM=linux LOCALE_PRESET=$LOCALE KEYTABLE_PRESET=$KEYTABLE TIMEZONE_PRESET=$TIMEZONE PASSWORD_ALREADY_SET=1
		ExecStartPost=/usr/sbin/langset.sh $LOCALE $KEYTABLE
	EOF
fi

[lnussel]

unless you have to meet deadlines so you have to accept hacks I'd recommend to find a better way instead :)

[Vogtinator]

What I suggested in #44 is to just add

EnvironmentFile=-/usr/share/defaults/jeos-firstboot.conf
EnvironmentFile=-/etc/jeos-firstboot.conf

to the .service file and use that for configuration. Alternatively, just sourcing those files inside jeos-firstboot.

[aplanas]

@Vogtinator This makes sense to me. I will change the .service, as is a more clear way.

But I wonder if this does not change the current code in this patch.

[aplanas]

@Vogtinator if I do a source inside the code, am I breaking the usage of LOCALE_PRESET and KEYTABLE_PRESET?

[Vogtinator]

No - if those variables are set in one of the files, it's skipped as it should be. The name of those variables should be changed though to accommodate for the newly gained external visibility.

[aplanas]

@Vogtinator @lnussel Added the configuration file and renamed the variables. Note that there are two exports for LOCALE_PRESET and KEYTABLE_PRESET that I maintained, as I am not sure if any other process are using them later.

[lnussel]

&& is not -e safe. Use inverse logic or the if variant.

[Vogtinator]

&& is not -e safe. Use inverse logic or the if variant.

It actually is:

The ERR trap is not executed if the failed command is part of the command list immediately following a while or until keyword, part of the test in an if statement, part of a command executed in a && or || list except the command following the final && or ||, any command in a pipeline but the last, or if the command's return value is being inverted using !. These are the same conditions obeyed by the errexit (-e) option.

[aplanas]

I agree with @Vogtinator. Will exit if cannot read the file at the end of the chain (tested locally)

[aplanas]

Rename the reexport, as is only used in the second virtual console. Not sure why there is a second virtual console involved, tho.

[aplanas]

Partially tested with:

#======================================
# Config for jeos-firstboot (Yomi)
#--------------------------------------
if [[ "$kiwi_profiles" == *"Live"* ]]; then
	cat > /etc/jeos-firstboot.conf <<-EOF
		JEOS_LOCALE="en_US"
		JEOS_KEYTABLE="jp"
		JEOS_TIMEZONE="UTC"
		JEOS_PASSWORD_ALREADY_SET=1
	EOF
fi

Ready for reviews

[Vogtinator]

Yes, those variables can come from two sources, but that won't actually matter. If it's set in the configuration file, the user isn't even asked, so it can't be overwritten.

[aplanas]

Not very confident of the last PR. I will test it manually, and lets see what openQA says.

[Vogtinator]

Found some typos, but will fix them after testing