Gmoro #62
Merged
Gmoro #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 21, 2020 14:57
Fix capitalisation on messages Fix logic operation to ignore wireless config
Create an ifcfg-* config for all non wireless interfaces even when the cable is disconnected
Vogtinator
requested changes
Jan 21, 2020
| d=${p##*/} | ||
|
|
||
| # On Rpi create a configuration file for each interface detected | ||
| # even when no cable connected |
There was a problem hiding this comment.
That needs some discussion:
- Runs even on non-RPi. The
is_raspberrycheck is below. - Why just for the RPi? It's an unexpected difference
- It can be a (negative) surprise in general to have this configured for an unused interface. There should at least be a dialog "DHCP enabled for these interfaces: eth0"
There was a problem hiding this comment.
Yeah, let's discuss that later then.
There was a problem hiding this comment.
I changed to have all interfaces configured with DHCP, at least while we don't have a way to re-run the network configuration standalone, and just for RPi as if applied to the virtual ones would be a difference in behaviour (currently we configure just the first one connected).
added 4 commits
January 28, 2020 08:08
drop useless comment
Create DHCP config for network devices with no cable connected
Vogtinator
requested changes
Feb 20, 2020
added 4 commits
February 21, 2020 15:47
Vogtinator
requested changes
Feb 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bsc#1161068
Fix coding style and some UI parts