Refactor #74
Merged
Refactor #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
November 24, 2020 12:03
add apply functions to locale/keytable
Vogtinator
requested changes
Nov 24, 2020
There was a problem hiding this comment.
Please run shellcheck and fix the reported errors. Indentation has to be fixed to be consistent.
jeos-firstboot-functions needs to be cleaned up, currently it's just a place where all kinds of stuff is in. Separating the "built-in" dialogs into module files might work.
Now there's a separate module hook needed for supporting jeos-config, but modules without that would still be shown in the list, but fail to run. Not sure what to do about that though.
Co-authored-by: Fabian Vogt <fabian@ritter-vogt.de>
Vogtinator
requested changes
Feb 2, 2021
Vogtinator
requested changes
Feb 2, 2021
added 8 commits
February 11, 2021 12:35
|
Anything else missing, would be good to merge that soon as there are other stuff to be merged. |
Vogtinator
requested changes
Feb 18, 2021
Vogtinator
reviewed
Feb 18, 2021
Vogtinator
requested changes
Feb 18, 2021
Vogtinator
reviewed
Feb 23, 2021
Vogtinator
approved these changes
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major refactor of the code base
Will use this as base for new scheme of branched and tagged releases from now on