Improve menu appearance #78
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For consistency. Otherwise the product title disappears sometimes.
Currently it always passes the maximum number of menu items which fit on the screen, which isn't ideal if there are fewer items to display. To avoid wasting space, never return more than the number of items.
|
Apparently the bug with the empty lines at the bottom got fixed in dialog recently! https://openqa.opensuse.org/tests/1692837#step/firstrun/5 So we just need https://bugzilla.opensuse.org/show_bug.cgi?id=1184503 fixed and then it should look nice everywhere |
|
Got applied as part of #79 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consistent appearance and less empty space inside the dialog.
While
dialog --menuallows to specify the total dialog width, height and menu item count, I was unable to find a way to get the dialog box just small enough to contain the description and menu items. There are always two empty lines below the menu list, unless we really compute dialog and menu height dynamically everywhere, which might get complex with translations and various terminal sizes...Everything automatic results in empty lines and will overflow the backtitle if there are too many items:
dialog --menu "Choose wisely" 0 0 0 Value1 "" Value2 "":The overflowing can be avoided by setting the menu height explicitly, which is what this PR does, but the empty lines remain:
dialog --menu "Choose wisely" 0 0 2 Value1 "" Value2 "":By specifying the dialog height as items+5, the empty lines disappear:
dialog --menu "Choose wisely" 7 0 0 Value1 "" Value2 ""For some reason the dialog height is ignored when there are more items than can fit - it fills the entire screen anyway!
dialog --menu "Choose wisely" 20 0 0 $(seq 1 100)(screenshot omitted)
However, by specifying the menu item height explicitly as well, it's suddenly honoured again, even if the menu height is too big to fit:
dialog --menu "Choose wisely" 20 0 30 $(seq 1 100)The behaviour gets really weird in that case though, because
dialog --menu "Choose wisely" 7 0 0 Value1 "" Value2 ""anddialog --menu "Choose wisely" 7 0 2 Value1 "" Value2 ""behave differently, even though they shouldn't. I assume this is because of the two empty lines at the bottom.Any idea?
Marked as draft because I didn't check it inside jeos-firstboot yet, only outside.