Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for shellcheck #97

Merged
merged 3 commits into from
Jan 18, 2024
Merged

Conversation

Vogtinator
Copy link
Member

@Vogtinator Vogtinator commented Apr 14, 2022

TODO:

  • Apply manual fixups
  • Test
  • Integrate into CI

Fixes #95

@Vogtinator
Copy link
Member Author

To run shellcheck: find files/usr/sbin files/usr/share/jeos-firstboot -type f -print0 | xargs -0 shellcheck

Vogtinator and others added 3 commits October 31, 2023 16:27
That makes it possible to run them without installing jeos-firstboot
system-wide first.

Co-authored-by: Ludwig Nussel <ludwig.nussel@suse.de>
To allow it to find and evaluate sourced files.

Co-authored-by: Ludwig Nussel <ludwig.nussel@suse.de>
@lnussel
Copy link
Member

lnussel commented Nov 30, 2023

what's missing?

@Vogtinator
Copy link
Member Author

Vogtinator commented Nov 30, 2023

Testing. I was busy with other more important stuff (as I told you).

@Vogtinator
Copy link
Member Author

Tested together with #111 and #112, works.

@Vogtinator Vogtinator merged commit 5a8e74a into openSUSE:master Jan 18, 2024
@Vogtinator Vogtinator deleted the shellcheck branch January 18, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make use of shellcheck
2 participants