Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable '-F' in lftp cls to avoid @ decorators #1

Merged
merged 1 commit into from
Oct 19, 2017

Conversation

alexjh
Copy link
Contributor

@alexjh alexjh commented Oct 18, 2017

When accessing pages on https://download.opensuse.org, I'm seeing a trailing @ on the version. It looks like lftp is adding decorators to the file names. The default seems to add this, so I'm wondering if the defaults changed recently to break this? Or could it be the layout of the page changed?

From an intercepted container:

bash-4.3# lftp -c "set -a" | grep cls
set cmd:cls-completion-default -FBa
set cmd:cls-default -F
set cmd:cls-exact-time yes

@@ -6,7 +6,7 @@ parse_source_config() {

get_listing() {
GLOB=$(echo "$REGEXP" | sed 's/(.*)/*/')
LISTING=$(lftp -c "open $URL; cls -1 $GLOB")
LISTING=$(lftp -c "open $URL; set cmd:cls-default ''; cls -1 $GLOB")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what other defaults might have been there before we reset it. Removing -F looks correct though.

@thardeck
Copy link
Collaborator

lgtm

@manno manno merged commit 568545c into openSUSE:master Oct 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants