Invalid free in pool_free (pool.c:120)

[mvidner]

While investigating a yast crash on openSUSE 13.1, valgrind points me to the line solv_free(pool->languages); in pool_free. It seems to me that if nlanguages == 0 then that pointer is uninitialized. I base that on pool_set_languages skipping it.

Workaround: export LANG=en_US.UTF-8 (it was empty in my JeoS before)

[mlschroe]

It can't be uninitialized, the pool is zero-filled in pool_create(). It seems like it gets freed twice when set_languages reduces the number of languages to zero. Will fix...

[mlschroe]

fixed with commit #d66d76b

I don't understand why the number of languages gets reduced, can you verify in the YaST log that this is the case? libzypp logs a "pool_set_languages" line for each call to pool_set_languages...

[mvidner]

http://pastebin.suse.de/8541 (internal pastebin :-/ , where else can I upload a log?) has 2 yast runs, 1st without LANG, 2nd with en_US.UTF8, both are a smoke test of the ncurses packaging widget and reinstall aaa_base-extras

[mvidner]

@mlschroe ping because of the log, I'm not sure whether you get notifications on closed issues

[mlschroe]

The one without LANG contains two calls:

PoolImpl.cc(setTextLocale):420 pool_set_languages: (en)
PoolImpl.cc(setTextLocale):420 pool_set_languages: ()

So it seems like my analysis is correct.

[mlschroe]

Ok, Michael Andres and me searched the code a bit.

libyui's YApplication::language() function uses "" as default, whereas libzypp's _autodetectTextLocale() uses "en" as default. Thus the difference.