Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testcase.h uses the Solver data type, include it. #10

Merged
merged 1 commit into from
Mar 14, 2012

Conversation

akozumpl
Copy link
Contributor

prevents compilation if the client doens't #inlcude solver otherwise.

Hi Michael,

I started working on some unit tests and hit the problem above^.

I wanted to ask: if I need some extension to the testing susetags format (e.g. give packages from @System a rpmdbid, something that really doesnt make a lot of sense outside the tests), can I just go ahead and add them to testcase_add_susetags() ? What would be the best way, new 'case's or maybe a callback parameter that would call back into my code for unrecognized tags? (maybe Im thinking too much ahead now..).

Thank you,
Ales

prevents compilation if the client doens't #inlcude solver otherwise.
mlschroe added a commit that referenced this pull request Mar 14, 2012
testcase.h uses the Solver data type, include it.
@mlschroe mlschroe merged commit 7f844f1 into openSUSE:master Mar 14, 2012
@mlschroe
Copy link
Member

Regarding the rpmdbid, you can just add a new tag, I think a callback is probably not needed for now.

But: the testcase parser currently only understands stuff that's used by the solver code, thus more or less only dependencies. It's not really intended for generic tests of the repo functions, you may want to use the repomd format instead or create the data on the fly in python.

@akozumpl
Copy link
Contributor Author

Yep, that's how I understand you intended it. I think with the few extending tags it could just cover hawkey's needs now, but if it starts getting out of hand I'll seek other repo formats etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants