Add support for flash-only bcache (with ABI compatibility) #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joseivanlopez
force-pushed
the
flash_bcache_keep_abi
branch
from
2fc8718
to
649c18c
Compare
joseivanlopez
changed the title
joseivanlopez
force-pushed
the
flash_bcache_keep_abi
branch
from
649c18c
to
95e2bd6
Compare
aschnell
reviewed
Jan 29, 2019
aschnell
reviewed
Jan 29, 2019
aschnell
reviewed
Jan 29, 2019
joseivanlopez
force-pushed
the
flash_bcache_keep_abi
branch
from
95e2bd6
to
b4190e3
Compare
aschnell
reviewed
Jan 30, 2019
- Part of fate#325346
- CompoundAction::find_by_target_device
joseivanlopez
force-pushed
the
flash_bcache_keep_abi
branch
from
b4190e3
to
5bd504d
Compare
|
The minor library version must be increased (LIBVERSION is 1.7.0). |
|
LGTM |
This was referenced Jan 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PBI: https://trello.com/c/T7taTEix/606-5-use-the-bcache-command-for-probing
This PR adds support for probing so-called "Flash-only" Bcache devices. Initially, another PR #603 was proposed. Although API offered by #603 might be more precise (IMHO), it breaks the ABI compatibility due to the Bcache API is modified.
Due to we need to preserve ABI compatibility during the whole SLE15 cycle, another approach has been implemented here, where the ABI compatibility is kept.
PR #603 should be taken into account for the future, when ABI changes will be allowed (i.e., for SLE16).
Note for reviewers: actions to create/delete Flash-only Bcache devices is out of scope. That will come with another PBI.