ProblemSolution::skipsPatchesOnly overload to handout the patches. #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlandres
force-pushed
the
ma-handout_skipped_pacthes
branch
from
f47b0dc
to
93996d0
Compare
mlandres
force-pushed
the
ma-handout_skipped_pacthes
branch
from
93996d0
to
53ac1a9
Compare
mlandres
force-pushed
the
ma-handout_skipped_pacthes
branch
from
53ac1a9
to
ed229dc
Compare
|
Functional changes are in the 1st commit. The 2nd one is just reorg and cleanup. |
bzeller
approved these changes
Feb 15, 2024
zypp/ProblemSolution.cc
Outdated
| } | ||
| // all true | ||
| if ( collector_r && remembered ) | ||
| collector_r->get().merge( std::move(remembered).value() ); |
There was a problem hiding this comment.
Suggested change
| collector_r->get().merge( std::move(remembered).value() ); | |
| collector_r->get().merge( std::move(remembered.value()) ); |
zypp/solver/detail/SolutionAction.h
Outdated
| @@ -62,8 +64,10 @@ namespace zypp | |||
| virtual bool execute (ResolverInternal & resolver) const = 0; | |||
|
|
|||
| public: | |||
| using PoolItemPredicate = std::pair<bool,std::optional<PoolItem>>; | |||
There was a problem hiding this comment.
Isn't a predicate in C++ terms usually a callable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.