Support reading AutoYaST profile from the QEMU fw_cfg #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See: https://git.qemu.org/?p=qemu.git;a=blob;f=docs/specs/fw_cfg.txt In order to pass the profile to the VM, the following QEMU command line is used: -fw_cfg name=opt/keyname,file=somedata.txt For the AutoYaST support, the key "opt/com.suse/autoinst" is used. So: -fw_cfg name=opt/com.suse/autoinst,file=autoinst.xml It is used as last resort, to allow overriding it with the media and the kernel command line options.
|
Finally, not needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://git.qemu.org/?p=qemu.git;a=blob;f=docs/specs/fw_cfg.txt
In order to pass the profile to the VM, the following QEMU command
line is used: -fw_cfg name=opt/keyname,file=somedata.txt
For the AutoYaST support, the key "opt/com.suse/autoinst" is used.
So: -fw_cfg name=opt/com.suse/autoinst,file=autoinst.xml
It is used as last resort, to allow overriding it with the media and
the kernel command line options.
TODO: document at https://en.opensuse.org/SDB:Linuxrc#AutoYaST_Profile_Handling if merged.
Reviewer note: I could had factored out some common code (parsing and network), however, giving the quirk of the parse function working with
file:/but notfile:///it was not possible to useconfig.autoyastthere, so the refactoring not worth it.