Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse 'try' keyword in ifcfg option (jsc#SLE-8965, jsc#SLE-9791) #219

Merged
merged 6 commits into from
Apr 2, 2020

Conversation

wfeldt
Copy link
Member

@wfeldt wfeldt commented Apr 1, 2020

Task

Add ´trykeyword toifcfg` option.

Solution

This is the parser code from #217 but using the simpler approach of copying the ifcfg value to config.ifcfg.manual - which is already used for exactly the intended purpose (iterating through network device list until an interface works).

A copy of url_device is needed - not a reference. Else there will be side
effects.
Travis for some reason fails with "permission error" when runnig "ls"
command. Running it with "--privileged" option fixed this.
@wfeldt wfeldt mentioned this pull request Apr 1, 2020
Copy link
Member

@mchf mchf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

passed through same tests as the previous PR and worked, so get finally get it finished. Thanks for help.

@wfeldt wfeldt merged commit 34b848c into master Apr 2, 2020
@wfeldt wfeldt deleted the sw_30 branch April 2, 2020 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants