Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the possibility to use a custom goproxy and parse dsc if present #23

Closed
wants to merge 7 commits into from

Conversation

jjacque
Copy link

@jjacque jjacque commented Feb 2, 2023

One way to allow building vendor archive (or even to download dependencies) when private repos are involved is to use an authenticating proxy (ie: https://github.com/goproxy/goproxy).
This PR includes some changes / refacto:

  • homogenise files / dirs handling using pathlib
  • fix various pylint errors:
    • % in logging instead of fstrings
    • create a dedicated function for _create_vendor_archive and _get_gomoddir
    • make functions "private" (no need for docstring)
  • add a bit of typing
  • use environment variables to define the proxy address (GOPROXY) and the private repos (GONOSUMDB) (see https://go.dev/ref/mod#private-modules)
  • also parse dsc when looking for version (in _source_archive_autodetect)

I integrated #8 in this PR (otherwise the service is constantly failing)

@jjacque jjacque changed the title Add the possibility to use a custom goproxy and allow parsing dsc Add the possibility to use a custom goproxy and parse dsc if present Feb 2, 2023
@jjacque
Copy link
Author

jjacque commented Oct 21, 2023

Splited in 2 PRs (only for the dsc and goproxy features):

@jjacque jjacque closed this Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant