Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a Makefile #3

Closed

Conversation

stefanotorresi
Copy link

Just to ease installing the service, similarly to all the other source services.

@stefanotorresi
Copy link
Author

ping @jfkw

@jfkw
Copy link
Collaborator

jfkw commented Mar 25, 2020

Thanks for the PR @stefanotorresi , I have been considering. The service is currently contained in one Python file and its XML definition, and as such the rpm packaging hasn't needed it. Of the 24 OBS source services for which I have local clones, 9 do have Makefiles.

So I understand and document the use case if accepting, do you view the presence of the Makefile as helpful for: local development/execution from an unpackaged install (git clone), improved packaging through rpm automation leveraging a Makefile, running the service on other distros, or other benefit?

@stefanotorresi
Copy link
Author

That's a very fair point!

Admittedly, by "all the other source services" I meant "all the other that I have personally used so far"; I evidently was too quick at jumping to the conclusion that all of them provide Makefiles, as you now make me aware that this is not actually the case.

The main use case here is manual installation. It may be in a local environment for testing, in a non-rpm distro, or a container.
Not so much the RPM packaging instead: I would say that, in simple services like this one, a Makefile doesn't really add much to the common RPM macros.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants