Refactoring #11
Merged
Refactoring #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ChrisBr
commented
Nov 29, 2017
ChrisBr
commented
- Fix bnc#1064307 (https://bugzilla.opensuse.org/show_bug.cgi?id=1064307)
- Implemented rspec test suite
- Splitted scripts in single classes
to implement specs and follow Single Responsibility principle.
to implement specs and follow Single Responsibility principle.
to implement specs and follow Single Responsibility principle.
this is necessary to install the service to /usr/lib/obs/services.
to implement specs and follow Single Responsibility principle.
to implement specs and follow Single Responsibility principle.
to make it easier to test and reuse
Fix bnc#1064307
when output directory is not specified
because it is ugly! Exception can be rescued and have the same result in this case
|
Updated spec file is here: https://build.opensuse.org/package/show/home:cbruckmayer:branches:openSUSE:Tools/obs-service-kiwi_import Has now a similar structure as https://github.com/openSUSE/obs-service-tar_scm |
otherwise ruby can not require the files
otherwise KiwiArchive.new.create_import!.is_sle? would fail
|
Please ping me before merging that I can update the spec file before! |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.