Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce defining dependencies in gemspec #49

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Enforce defining dependencies in gemspec #49

merged 1 commit into from
Sep 13, 2023

Conversation

saraycp
Copy link
Contributor

@saraycp saraycp commented Sep 13, 2023 •
edited
Loading

The latest open PRs linters failed with:

Offenses:

obs_github_deployments.gemspec:33:3: C: Gemspec/DevelopmentDependencies: Specify development dependencies in Gemfile.
  spec.add_development_dependency "pry-byebug", "~> 3"
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  
[...]

3 files inspected, 8 offenses detected

Rubocop suggests defining them in Gemfile by default. But I propose to leave them in obs_github_deployments.gemspec for now.

@saraycp
Enforce defining dependencies in gemspec
6d87e24 
On the current implementation, the dependencies are defined in
obs_github_deployments.gemspec. They are going to stay there for now.
@saraycp saraycp marked this pull request as ready for review September 13, 2023 10:48
@saraycp saraycp merged commit 0698e35 into openSUSE:main Sep 13, 2023
1 check passed
@saraycp saraycp deleted the dependencies_cop branch September 13, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellcp-work hellcp-work hellcp-work approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@saraycp @hellcp-work