Merge pull request #9903 from openSUSE/depfu/update/srcapi/rubocop-rs…

…pec-1.42.0

[src/api] Update rubocop-rspec: 1.40.0 → 1.42.0 (minor)

.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config --auto-gen-only-exclude --exclude-limit 100`
-# on 2020-06-29 08:27:45 UTC using RuboCop version 0.86.0.
+# on 2020-07-27 13:50:10 UTC using RuboCop version 0.88.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -30,7 +30,7 @@ Metrics/AbcSize:
     - 'dist/openQA_mail_notification.rb'
 
 # Offense count: 6
-# Configuration parameters: CountComments, Max, ExcludedMethods.
+# Configuration parameters: CountComments, Max, CountAsOne, ExcludedMethods.
 # ExcludedMethods: refine
 Metrics/BlockLength:
   Exclude:
@@ -40,7 +40,7 @@ Metrics/BlockLength:
     - 'dist/t/spec/features/0040_package_spec.rb'
 
 # Offense count: 7
-# Configuration parameters: CountComments, Max, ExcludedMethods.
+# Configuration parameters: CountComments, Max, CountAsOne, ExcludedMethods.
 Metrics/MethodLength:
   Exclude:
     - 'dist/clouduploader.rb'

src/api/.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config --auto-gen-only-exclude --exclude-limit 100`
-# on 2020-07-10 16:04:26 UTC using RuboCop version 0.87.1.
+# on 2020-07-27 13:52:25 UTC using RuboCop version 0.88.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -74,7 +74,7 @@ Lint/UriEscapeUnescape:
     - 'spec/models/package_spec.rb'
     - 'test/functional/request_controller_test.rb'
 
-# Offense count: 881
+# Offense count: 880
 # Configuration parameters: IgnoredMethods.
 Metrics/AbcSize:
   Max: 195
@@ -274,7 +274,7 @@ Metrics/CyclomaticComplexity:
     - 'test/functional/zzz_post_consistency_test.rb'
     - 'test/node_matcher.rb'
 
-# Offense count: 927
+# Offense count: 928
 # Configuration parameters: CountComments, CountAsOne, ExcludedMethods.
 Metrics/MethodLength:
   Max: 227
@@ -304,7 +304,7 @@ Metrics/ParameterLists:
     - 'test/functional/source_controller_test.rb'
     - 'test/test_helper.rb'
 
-# Offense count: 179
+# Offense count: 176
 # Configuration parameters: IgnoredMethods, Max.
 Metrics/PerceivedComplexity:
   Exclude:
@@ -373,7 +373,6 @@ Metrics/PerceivedComplexity:
     - 'app/models/project/update_from_xml_command.rb'
     - 'app/models/relationship.rb'
     - 'app/models/repository.rb'
-    - 'app/models/review.rb'
     - 'app/models/service.rb'
     - 'app/models/unregistered_user.rb'
     - 'app/models/user.rb'
@@ -448,7 +447,7 @@ Naming/MethodName:
 
 # Offense count: 57
 # Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
-# AllowedNames: io, id, to, by, on, in, at, ip, db, os, pp
+# AllowedNames: at, by, db, id, in, io, ip, of, on, os, pp, to
 Naming/MethodParameterName:
   Exclude:
     - 'app/controllers/search_controller.rb'
@@ -626,7 +625,7 @@ RSpec/EmptyLineAfterFinalLet:
     - 'spec/support/shared_examples/features/boostrap_flag_tables.rb'
     - 'spec/support/shared_examples/features/flags_tables.rb'
 
-# Offense count: 319
+# Offense count: 317
 # Configuration parameters: Max.
 RSpec/ExampleLength:
   Exclude:
@@ -744,12 +743,12 @@ RSpec/IteratedExpectation:
   Exclude:
     - 'spec/models/user_spec.rb'
 
-# Offense count: 274
+# Offense count: 279
 # Cop supports --auto-correct.
 RSpec/LeadingSubject:
   Enabled: false
 
-# Offense count: 374
+# Offense count: 403
 RSpec/LetSetup:
   Exclude:
     - 'spec/controllers/cloud/upload_jobs_controller_spec.rb'
@@ -842,6 +841,11 @@ RSpec/LetSetup:
     - 'spec/queries/projects_with_image_templates_finder_spec.rb'
     - 'spec/queries/projects_with_very_important_attribute_finder_spec.rb'
     - 'spec/services/package_service/schema_verifier_spec.rb'
+    - 'spec/support/shared_contexts/a_bs_request_with_reviews.rb'
+    - 'spec/support/shared_contexts/a_project_with_maintenance_statistics.rb'
+    - 'spec/support/shared_contexts/a_set_of_bs_requests.rb'
+    - 'spec/support/shared_contexts/a_user_and_subscriptions.rb'
+    - 'spec/support/shared_contexts/a_user_and_subscriptions_with_defaults.rb'
     - 'spec/support/shared_examples/features/beta/user_tab.rb'
     - 'spec/support/shared_examples/features/boostrap_flag_tables.rb'
     - 'spec/support/shared_examples/features/bootstrap_user_tab.rb'
@@ -1338,7 +1342,7 @@ Style/ConditionalAssignment:
 Style/Documentation:
   Enabled: false
 
-# Offense count: 1428
+# Offense count: 1429
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: always, always_true, never
@@ -1555,7 +1559,7 @@ Style/RedundantReturn:
     - 'app/services/package_controller_service/url_generator.rb'
     - 'test/node_matcher.rb'
 
-# Offense count: 88
+# Offense count: 87
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, AllowInnerSlashes.
 # SupportedStyles: slashes, percent_r, mixed
@@ -1566,7 +1570,6 @@ Style/RegexpLiteral:
     - 'app/controllers/public_controller.rb'
     - 'app/controllers/webui/monitor_controller.rb'
     - 'app/controllers/webui/package_controller.rb'
-    - 'app/controllers/webui/repositories_controller.rb'
     - 'app/controllers/webui/sitemaps_controller.rb'
     - 'app/controllers/webui/webui_controller.rb'
     - 'app/helpers/webui/webui_helper.rb'
@@ -1647,7 +1650,7 @@ Style/SymbolArray:
 Style/WordArray:
   Enabled: false
 
-# Offense count: 1823
+# Offense count: 1830
 # Cop supports --auto-correct.
 # Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
 # URISchemes: http, https

src/api/Gemfile.lock

@@ -352,8 +352,8 @@ GEM
       activesupport (>= 4.2.0)
       rack (>= 1.1)
       rubocop (>= 0.82.0)
-    rubocop-rspec (1.40.0)
-      rubocop (>= 0.68.1)
+    rubocop-rspec (1.42.0)
+      rubocop (>= 0.87.0)
     ruby-ldap (0.9.20)
     ruby-progressbar (1.10.1)
     ruby_parser (3.14.2)