Skip to content

Commit

Permalink
[ci] Refactor #update_build_log test for multibuild package
Browse files Browse the repository at this point in the history
to check for the instance variable offset instead of calling the get_size function.
This will make it easier to refactor in the future as it does not depend on the internal implementation anymore.
  • Loading branch information
ChrisBr committed Apr 19, 2017
1 parent 3c07e72 commit 0739748
Show file tree
Hide file tree
Showing 8 changed files with 130 additions and 245 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

This file was deleted.

This file was deleted.

This file was deleted.

22 changes: 9 additions & 13 deletions src/api/spec/controllers/webui/package_controller_spec.rb
Expand Up @@ -859,21 +859,17 @@ def do_request(params)
arch: architecture.name}
}

context 'instance variables' do
before do
do_request params
end

it { expect(assigns(:log_chunk)).not_to be_nil }
it { expect(assigns(:package)).to eq("#{source_package}:multibuild-package") }
it { expect(assigns(:project)).to eq(source_project) }
end

it "should call 'get_size_of_log' with appropriate arguments" do
expect(controller).to receive(:get_size_of_log).
with(source_project, "#{source_package}:multibuild-package", repo_leap_42_2.name, architecture.name)
before do
path = "#{CONFIG['source_url']}/build/#{source_project}/#{repo_leap_42_2}/i586/#{source_package}:multibuild-package/_log?view=entry"
body = "<directory><entry name=\"_log\" size=\"#{32 * 1024}\" mtime=\"1492267770\" /></directory>"
stub_request(:get, path).and_return(body: body)
do_request params
end

it { expect(assigns(:log_chunk)).not_to be_nil }
it { expect(assigns(:package)).to eq("#{source_package}:multibuild-package") }
it { expect(assigns(:project)).to eq(source_project) }
it { expect(assigns(:offset)).to eq(0) }
end
end
end
Expand Down

0 comments on commit 0739748

Please sign in to comment.