[backend] make targetdata binary safe

openSUSE · Dec 15, 2017 · 09881a4 · 09881a4
1 parent bb607ec
commit 09881a4
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/backend/BSXML.pm b/src/backend/BSXML.pm
@@ -1883,7 +1883,6 @@ our $clouduploadjob = [
 	'size',
 
 	'pid',		# internal
-	'targetdata',	# internal
 ];
 
 1;
diff --git a/src/backend/bs_clouduploadserver b/src/backend/bs_clouduploadserver
@@ -120,8 +120,9 @@ sub cloudupload_create {
     die("$_ is missing from job skeleton\n") unless defined $jobskel->{$_};
     $job->{$_} = $jobskel->{$_};
   }
-  my $targetdata = delete $jobskel->{'targetdata'};
+  my $targetdata = delete $jobskel->{'details'};
   $targetdata = '' unless defined $targetdata;
+  $targetdata = pack('H*', $targetdata);
   my $jobid = nextjobid();
   $job->{'name'} = $jobid;
   $job->{'state'} = 'created';

diff --git a/src/backend/bs_srcserver b/src/backend/bs_srcserver
@@ -6129,7 +6129,7 @@ sub cloudupload_create {
     'filename' => $filename,
     'user' => $cgi->{'user'},
     'target' => $cgi->{'target'},
-    'targetdata' => $targetdata,
+    'details' => unpack('H*', $targetdata),
   };
   my $param = {
     'uri' => "$reposerver/build/$projid/$repoid/$arch/$packid/$filename",