Skip to content

Commit

Permalink
Fix flickering popover for build results
Browse files Browse the repository at this point in the history
The build result popover can become very long, eg. when there are
many unresolvable package dependencies.
When this happens the popover would overlap with the link it belongs to
and thus would start to flicker when hovering over it (switching from
hovering state and back in a loop).

By displaying the popover on the right side of the link we prevent this
from happening.

Fixes #6200
  • Loading branch information
bgeuken authored and coolo committed Nov 14, 2018
1 parent 81e5a00 commit 0b6e930
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/api/app/helpers/webui/buildresult_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -64,11 +64,11 @@ def webui2_arch_repo_table_cell(repo, arch, package_name, status = nil, enable_h
data: { content: Buildresult.status_description(status['code']), placement: 'top', toggle: 'popover' }))
end
if code.in?(['-', 'unresolvable', 'blocked', 'excluded', 'scheduled'])
concat(link_to(code, 'javascript:void(0);', id: status_id, class: theclass, data: { content: link_title, placement: 'top', toggle: 'popover' }))
concat(link_to(code, 'javascript:void(0);', id: status_id, class: theclass, data: { content: link_title, placement: 'right', toggle: 'popover' }))
else
concat(link_to(code.gsub(/\s/, ' '),
package_live_build_log_path(project: @project.to_s, package: package_name, repository: repo, arch: arch),
data: { content: link_title, placement: 'top', toggle: 'popover' }, rel: 'nofollow', class: theclass))
data: { content: link_title, placement: 'right', toggle: 'popover' }, rel: 'nofollow', class: theclass))
end
end
end
Expand Down

0 comments on commit 0b6e930

Please sign in to comment.