Skip to content

Commit

Permalink
[backend] strip also invalid person and group data from remote projec…
Browse files Browse the repository at this point in the history
…t meta (fixes webui crashes)
  • Loading branch information
adrianschroeter committed Mar 8, 2013
1 parent 8bd6965 commit 165066e
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 1 deletion.
11 changes: 10 additions & 1 deletion src/api/test/functional/interconnect_test.rb
Expand Up @@ -451,14 +451,23 @@ def test_setup_remote_propject
assert_response :success
end

def test_check_package_meta_stripping
def test_check_meta_stripping
prepare_request_with_user "Iggy", "asdfasdf"
# package meta
get "/source/home:Iggy/TestPack/_meta"
assert_response :success
assert_xml_tag :tag => 'person'
get "/source/RemoteInstance:home:Iggy/TestPack/_meta"
assert_response :success
assert_no_xml_tag :tag => 'person'

# project meta
get "/source/home:Iggy/_meta"
assert_response :success
assert_xml_tag :tag => 'person'
get "/source/RemoteInstance:home:Iggy/_meta"
assert_response :success
assert_no_xml_tag :tag => 'person'
end

def test_remove_broken_link
Expand Down
2 changes: 2 additions & 0 deletions src/backend/bs_srcserver
Expand Up @@ -2917,6 +2917,8 @@ sub getproject {
for my $pp (@{$p->{'link'} || []}) {
$pp->{'project'} = maptoremote($proj, $pp->{'project'});
}
delete $p->{'person'};
delete $p->{'group'};
$p->{'mountproject'} = $proj->{'root'} if defined $proj->{'root'};
$proj = $p;
}
Expand Down

0 comments on commit 165066e

Please sign in to comment.