Merge pull request #4230 from evanrolfe/fix/create_project_log_entry

[webui][api] Fix CreateProjectLogEntryJob when the entry was not persisted
openSUSE · Dec 19, 2017 · 18f40e2 · 18f40e2
2 parents 77ecab5 + 2cde871
commit 18f40e2
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/api/app/jobs/create_project_log_entry_job.rb b/src/api/app/jobs/create_project_log_entry_job.rb
@@ -3,7 +3,9 @@ class CreateProjectLogEntryJob < ApplicationJob
 
   def perform(event_id)
     event = Event::Base.find(event_id)
-    entry = ProjectLogEntry.create_from(event)
-    event.update_attributes(project_logged: true) if entry.persisted?
+    # If the ProjectLogEntry was invalid then we still mark the event as logged
+    event.update_attributes(project_logged: true)
+
+    ProjectLogEntry.create_from(event)
   end
 end