Merge pull request #2974 from bgeuken/update_user_pw_stuff

Update user fake pw creation

src/api/app/models/user.rb

@@ -179,11 +179,7 @@ def self.update_notifications(params, user = nil)
   end
 
   def self.create_user_with_fake_pw!(attributes = {})
-    chars = ["A".."Z", "a".."z", "0".."9"].collect(&:to_a).join
-    fakepw = (1..24).collect { chars[rand(chars.size)] }.pack("a" * 24)
-
-    attributes[:password] = fakepw
-    create!(attributes)
+    create!(attributes.merge(password: SecureRandom.base64(48)))
   end
 
   # This static method tries to find a user with the given login and password

src/api/spec/models/user_spec.rb

@@ -273,6 +273,10 @@
       let(:user) { User.create_user_with_fake_pw!({ login: 'tux', email: 'some@email.com' }) }
 
       it 'creates a user with a fake password' do
+        expect(user.password).not_to eq(User.create_user_with_fake_pw!({ login: 'tux2', email: 'some@email.com' }).password)
+      end
+
+      it 'creates a user from given attributes' do
         expect(user).to be_an(User)
         expect(user.login).to eq('tux')
         expect(user.email).to eq('some@email.com')