Merge pull request #4092 from DavidKang/factory_bot

Replace FactoryGirlRails with FactoryBotRails

src/api/Gemfile

@@ -143,7 +143,7 @@ group :development, :test do
   # as testing framework
   gem 'rspec-rails', '~> 3.5.0'
   # for fixtures
-  gem 'factory_girl_rails'
+  gem 'factory_bot_rails'
   # for mocking the backend
   gem 'vcr'
   # as alternative to the standard IRB shell

src/api/Gemfile.lock

@@ -119,10 +119,10 @@ GEM
     erubi (1.7.0)
     escape_utils (1.2.1)
     execjs (2.7.0)
-    factory_girl (4.8.0)
+    factory_bot (4.8.2)
       activesupport (>= 3.0.0)
-    factory_girl_rails (4.8.0)
-      factory_girl (~> 4.8.0)
+    factory_bot_rails (4.8.2)
+      factory_bot (~> 4.8.2)
       railties (>= 3.0.0)
     faker (1.8.4)
       i18n (~> 0.5)
@@ -446,7 +446,7 @@ DEPENDENCIES
   database_cleaner (>= 1.0.1)
   delayed_job_active_record (>= 4.0.0)
   escape_utils
-  factory_girl_rails
+  factory_bot_rails
   faker
   feature
   flog (> 4.1.0)

src/api/config/application.rb

@@ -121,10 +121,10 @@ class Application < Rails::Application
     # we're not threadsafe
     config.allow_concurrency = false
 
-    # we don't want factory_girl to interfer with the legacy test suite
+    # we don't want factory_bot to interfer with the legacy test suite
     # based on minitest
     config.generators do |g|
-      g.factory_girl false
+      g.factory_bot false
       g.test_framework :rspec
     end
 

src/api/spec/README.md

@@ -60,8 +60,8 @@ We are using the standard [RSpec generators](https://relishapp.com/rspec/rspec-r
 `rails generate rspec:model package` or
 `rails generate rspec:controller webui::blah`
 
-### Factory Girl
-We use [Factory Girl](https://github.com/thoughtbot/factory_girl_rails) to create our ruby objects, make sure to get familiar with the factory girl [features and syntax](http://www.rubydoc.info/gems/factory_girl/file/GETTING_STARTED.md).
+### Factory Bot
+We use [Factory Bot](https://github.com/thoughtbot/factory_bot_rails) to create our ruby objects, make sure to get familiar with the factory bot [features and syntax](http://www.rubydoc.info/gems/factory_bot/file/GETTING_STARTED.md).
 Be aware of that factories, other than fixtures, run through ActiveRecord validations.
 All OBS factories reside in `spec/factories`.
 
@@ -72,10 +72,10 @@ For creating has_many associations we prefer ```create_list```:
 project.packages = create_list(:package, 2)
 ```
 
-Please also have a look at the [factory girl documentation](https://github.com/thoughtbot/factory_girl/blob/master/GETTING_STARTED.md#associations)
+Please also have a look at the [factory bot documentation](https://github.com/thoughtbot/factory_bot/blob/master/GETTING_STARTED.md#associations)
 
 #### Use a sequence for unique values
-It's necessary to use a [sequence](https://github.com/thoughtbot/factory_girl/blob/master/GETTING_STARTED.md#sequences) for attributes which have to be unique like project.title or user.login.
+It's necessary to use a [sequence](https://github.com/thoughtbot/factory_bot/blob/master/GETTING_STARTED.md#sequences) for attributes which have to be unique like project.title or user.login.
 
 ```
 sequence(:login) { |n| "user_#{n}" }
@@ -91,7 +91,7 @@ let!(:user) { create(:confirmed_user, login: "proxy_user") }
 By passing ```login: "proxy_user"``` to the create statement, the username is now always proxy_user and not random (e.g. user_42).
 
 #### Factories should be the bare minimum
-Different to fixtures, factory girl runs through your ActiveRecord validations.
+Different to fixtures, factory bot runs through your ActiveRecord validations.
 That said, only add the bare minimum to your factory which is required to be valid.
 You can use an inherited factory to add or override attributes.
 
@@ -110,7 +110,7 @@ You can use an inherited factory to add or override attributes.
 See this [blog article](https://robots.thoughtbot.com/factories-should-be-the-bare-minimum) for a detailed explanation.
 
 #### When Transient Attributes make sense
-Use [transient attributes](https://github.com/thoughtbot/factory_girl/blob/master/GETTING_STARTED.md#transient-attributes) to DRY your factories.
+Use [transient attributes](https://github.com/thoughtbot/factory_bot/blob/master/GETTING_STARTED.md#transient-attributes) to DRY your factories.
 
 ```
   factory :project_with_package do

src/api/spec/factories/architecture.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :architecture do
     sequence(:name) { |n| "arch_factory_#{n}" }
   end

src/api/spec/factories/attrib_allowed_values.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :attrib_allowed_value do
   end
 end

src/api/spec/factories/attrib_default_values.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :attrib_default_value do
     attrib_type { create(:attrib_type) }
     position 1

src/api/spec/factories/attrib_namespaces.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :attrib_namespace do
     name { Faker::Lorem.word }
   end

src/api/spec/factories/attrib_types.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :attrib_type do
     sequence(:name) { |n| "attribute_factory_#{n}" }
     attrib_namespace

src/api/spec/factories/attrib_values.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :attrib_value do
     attrib
     # this is necessary! otherwise the default value will not be recognized.

src/api/spec/factories/attribs.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :attrib do
     attrib_type
     project

src/api/spec/factories/bs_request_actions.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :bs_request_action do
     factory :bs_request_action_add_maintainer_role do
       type 'add_role'

src/api/spec/factories/bs_requests.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :bs_request do
     description { Faker::Lorem.paragraph }
     state "new"

src/api/spec/factories/comments.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :comment do
     body { Faker::Lorem.paragraph }
     user

src/api/spec/factories/configuration.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :configuration do
     name { Faker::Lorem.word }
     title { Faker::Lorem.word }

src/api/spec/factories/distribution.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :distribution do
     vendor { Faker::Lorem.word }
     version "13.2"

src/api/spec/factories/download_repository_factory.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :download_repository do
     arch "x86_64"
     url "http://suse.com"

src/api/spec/factories/event_subscriptions.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :event_subscription do
     factory :event_subscription_comment_for_project do
       eventtype 'Event::CommentForProject'

src/api/spec/factories/flag.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :flag do
     project
     position 1

src/api/spec/factories/group_maintainers.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :group_maintainer do
     user { create(:user) }
     group { create(:group) }

src/api/spec/factories/groups.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :group do
     sequence(:title){ |n| "group_#{n}" }
     email { Faker::Internet.email }

src/api/spec/factories/groups_user.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :groups_user do
     user { create(:user) }
     group { create(:group) }

src/api/spec/factories/history_elements.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :history_element_review_assigned, class: 'HistoryElement::ReviewAssigned' do
     type { 'HistoryElement::ReviewAssigned' }
   end

src/api/spec/factories/issue.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :issue do
     name Faker::Lorem.words(5).join(' ')
 

src/api/spec/factories/issue_tracker.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :issue_tracker do
     name Faker::Lorem.words(5).join(' ')
     kind 'github'

src/api/spec/factories/kiwi_description.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :kiwi_description, class: Kiwi::Description do
     association :image, factory: :kiwi_image
 

src/api/spec/factories/kiwi_image.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :kiwi_image, class: Kiwi::Image do
     name { Faker::Name.name }
     md5_last_revision nil

src/api/spec/factories/kiwi_package.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :kiwi_package, class: Kiwi::Package do
     transient do
       image { create(:kiwi_image) }

src/api/spec/factories/kiwi_package_group.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :kiwi_package_group, class: Kiwi::PackageGroup do
     association :image, factory: :kiwi_image
 

src/api/spec/factories/kiwi_repository.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :kiwi_repository, class: Kiwi::Repository do
     association :image, factory: :kiwi_image
 

src/api/spec/factories/maintained_project.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :maintained_project do
     project
     maintenance_project

src/api/spec/factories/notification.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :notification do
     event_type 'FakeEventType'
     event_payload { { fake: 'payload' } }

src/api/spec/factories/package_issue.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :package_issue do
   end
 end

src/api/spec/factories/packages.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :package do
     project
     sequence(:name) { |n| "package_#{n}" }

src/api/spec/factories/path_element.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :path_element do
     sequence(:position) { |n| n }
     repository

src/api/spec/factories/project.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :project do
     sequence(:name) { |n| "project_#{n}" }
     title { Faker::Book.title }

src/api/spec/factories/project_log_entry.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :project_log_entry do
     project
     datetime { Time.zone.today }

src/api/spec/factories/relationship.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :relationship do
     role { Role.find_by_title('maintainer') }
 

src/api/spec/factories/release_target.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :release_target do
     repository
     target_repository { create(:repository) }

src/api/spec/factories/repository.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :repository do
     project
     sequence(:name) { |n| "repository_#{n}" }

src/api/spec/factories/repository_architecture.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :repository_architecture do
     repository
     architecture

src/api/spec/factories/review.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :review do
     state :new
 

src/api/spec/factories/role.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :role do
     sequence(:title) { |n| "role_#{n}" }
   end

src/api/spec/factories/status_history.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :status_history do
     transient do
       source 'source'

src/api/spec/factories/status_message.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :status_message do
     message { Faker::Lorem.paragraph }
     severity "Green"

src/api/spec/factories/users.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :user do
     email { Faker::Internet.email }
     realname { Faker::Name.name }

src/api/spec/factories/watched_projects.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :watched_project do
     project
     user

src/api/spec/rails_helper.rb

@@ -44,7 +44,7 @@
 end
 
 # support fixtures
-require 'support/factory_girl'
+require 'support/factory_bot'
 
 # support database cleanup
 require 'support/database_cleaner'

src/api/spec/support/database_cleaner.rb

@@ -6,7 +6,7 @@
                      architectures attrib_types
                      attrib_namespaces issue_trackers).freeze
 
-  # We are using factory_girl to set up everything the test needs up front,
+  # We are using factory_bot to set up everything the test needs up front,
   # instead of loading a set of fixtures in the beginning of the suite
   config.use_transactional_fixtures = false
 

src/api/spec/support/factory_bot.rb

@@ -0,0 +1,3 @@
+RSpec.configure do |config|
+  config.include FactoryBot::Syntax::Methods
+end