Skip to content

Commit

Permalink
[webui] don't link to raw log for inherited packages in staging prjs
Browse files Browse the repository at this point in the history
  • Loading branch information
coolo committed Jun 7, 2014
1 parent 9d4498a commit 1ea363f
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions src/api/app/controllers/webui/project_controller.rb
Expand Up @@ -1505,8 +1505,10 @@ def add_path(action)
def load_local_packages
unless @project.api_obj.linkedprojects.empty?
@localpackages = {}
@project.api_obj.packages.each do |p|
@localpackages[p[:name]] = 1
prjs = {}
find_packages_info.each do |p|
prjs[p[1]] ||= Project.find_by_name(p[1])
@localpackages[p[0]] = 1 unless prjs[p[1]].is_a? String
end
end
end
Expand Down

3 comments on commit 1ea363f

@adrianschroeter
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't that breaking again the logfile access to builds linking to remote projects?

@coolo
Copy link
Member Author

@coolo coolo commented on 1ea363f Jun 10, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for those the prj will be a string, no?

@coolo
Copy link
Member Author

@coolo coolo commented on 1ea363f Jun 10, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but as there is no test case to prove me wrong, I say I'm correct anyway

Please sign in to comment.