Merge pull request #9891 from hennevogel/bugfix/9890

Do not throw an error on missing search defaults

src/api/app/controllers/webui/search_controller.rb

@@ -155,10 +155,6 @@ def search
     end
 
     logger.debug "Searching for the string \"#{@search_text}\" in the #{@search_where}'s of #{@search_what}'s"
-    if @search_where.empty? && !@search_attrib_type_id && !@search_issue
-      flash[:error] = "You have to search for #{@search_text} in something. Click the advanced button..."
-      return
-    end
 
     @per_page = 20
     search = FullTextSearch.new(text: @search_text,

src/api/spec/controllers/webui/search_controller_spec.rb

@@ -88,15 +88,6 @@
       end
     end
 
-    context 'with no search scope' do
-      before do
-        get :index, params: { search_text: 'whatever' }
-      end
-
-      it { expect(flash[:error]).to eq('You have to search for whatever in something. Click the advanced button...') }
-      it { expect(response).to have_http_status(:success) }
-    end
-
     context 'with proper parameters but no results' do
       before do
         allow(ThinkingSphinx).to receive(:search).and_return([])

src/api/spec/features/beta/webui/search_spec.rb

@@ -133,26 +133,6 @@
       expect(page).to have_selector('#search-results', count: 0)
     end
 
-    it 'search in no fields' do
-      apache2
-
-      visit search_path
-      page.evaluate_script('$.fx.off = true;') # Needed to disable javascript animations that can end in not checking the checkboxes properly
-
-      fill_in 'search_input', with: 'awesome'
-      click_button 'Advanced'
-      uncheck 'title'
-      uncheck 'name'
-      uncheck 'description'
-      click_button 'Search'
-
-      within('#flash') do
-        expect(page).to have_text('You have to search for awesome in something. Click the advanced button...')
-      end
-
-      expect(page).to have_selector('#search-results', count: 0)
-    end
-
     it 'search Russian project in UTF-8' do
       russian_project
 

src/api/spec/features/webui/search_spec.rb

@@ -133,26 +133,6 @@
       expect(page).to have_selector('#search-results', count: 0)
     end
 
-    it 'search in no fields' do
-      apache2
-
-      visit search_path
-      page.evaluate_script('$.fx.off = true;') # Needed to disable javascript animations that can end in not checking the checkboxes properly
-
-      fill_in 'search_input', with: 'awesome'
-      click_button 'Advanced'
-      uncheck 'title'
-      uncheck 'name'
-      uncheck 'description'
-      click_button 'Search'
-
-      within('#flash') do
-        expect(page).to have_text('You have to search for awesome in something. Click the advanced button...')
-      end
-
-      expect(page).to have_selector('#search-results', count: 0)
-    end
-
     it 'search Russian project in UTF-8' do
       russian_project