Skip to content

Commit

Permalink
Squash two very related callbacks for the same set
Browse files Browse the repository at this point in the history
  • Loading branch information
ncounter committed Mar 28, 2024
1 parent 0c50e9b commit 24248cf
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions src/api/app/controllers/webui/request_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ class Webui::RequestController < Webui::WebuiController
if: -> { Flipper.enabled?(:request_show_redesign, User.session) }
before_action :set_influxdb_data_request_actions, only: %i[show build_results rpm_lint changes mentioned_issues],
if: -> { Flipper.enabled?(:request_show_redesign, User.session) }
before_action :set_diff_to_superseded_id, only: %i[show request_action request_action_changes build_results rpm_lint changes mentioned_issues]
before_action :set_superseded_request, only: %i[show request_action request_action_changes build_results rpm_lint changes mentioned_issues]
before_action :check_ajax, only: :sourcediff
before_action :prepare_request_data, only: %i[show build_results rpm_lint changes mentioned_issues],
Expand Down Expand Up @@ -353,12 +352,8 @@ def new_state
end
end

def set_diff_to_superseded_id
@diff_to_superseded_id = params[:diff_to_superseded]
end

def set_superseded_request
return unless @diff_to_superseded_id
return unless (@diff_to_superseded_id = params[:diff_to_superseded])

@diff_to_superseded = @bs_request.superseding.find_by(number: @diff_to_superseded_id)
return if @diff_to_superseded
Expand Down

0 comments on commit 24248cf

Please sign in to comment.