Do not capitalize class names in error messages

src/api/app/controllers/concerns/rescue_authorization_handler.rb

@@ -44,7 +44,7 @@ def authorization_message(exception)
       when :anonymous_user
         'Please login to access the resource'
       else
-        "Sorry, you are not authorized to #{action_for_exception(exception)} this #{ActiveSupport::Inflector.underscore(exception.record.class.to_s).humanize}."
+        "Sorry, you are not authorized to #{action_for_exception(exception)} this #{ActiveSupport::Inflector.underscore(exception.record.class.to_s).humanize(capitalize: false)}."
       end
     end
 

src/api/app/controllers/webui/groups_controller.rb

@@ -4,20 +4,20 @@ class Webui::GroupsController < Webui::WebuiController
   after_action :verify_authorized, except: [:show, :autocomplete]
 
   def index
-    authorize Group, :index?
+    authorize Group.new, :index?
     @groups = Group.all.includes(:users)
   end
 
   def show; end
 
   def new
-    authorize Group, :create?
+    authorize Group.new, :create?
   end
 
   def create
-    authorize Group, :create?
-
     group = Group.new(title: group_params[:title])
+    authorize group, :create?
+
     if group.save && group.replace_members(group_params[:members])
       flash[:success] = "Group '#{group}' successfully created."
       redirect_to controller: :groups, action: :index

src/api/app/controllers/webui/packages/branches_controller.rb

@@ -84,7 +84,7 @@ def create
         flash[:notice] = 'You have already branched this package'
         redirect_to(package_show_path(project: e.project, package: e.package))
       rescue CreateProjectNoPermission
-        flash[:error] = 'Sorry, you are not authorized to create this Project.'
+        flash[:error] = 'Sorry, you are not authorized to create this project.'
         redirect_back(fallback_location: root_path)
       rescue ArgumentError, Package::UnknownObjectError, Project::UnknownObjectError, APIError, ActiveRecord::RecordInvalid => e
         flash[:error] = "Failed to branch: #{e.message}"

src/api/spec/controllers/webui/download_on_demand_controller_spec.rb

@@ -45,7 +45,7 @@
       end
 
       it { is_expected.to redirect_to(root_path) }
-      it { expect(flash[:error]).to eq('Sorry, you are not authorized to create this Download repository.') }
+      it { expect(flash[:error]).to eq('Sorry, you are not authorized to create this download repository.') }
       it { expect(DownloadRepository.where(dod_parameters[:download_repository])).not_to exist }
     end
 
@@ -85,7 +85,7 @@
       end
 
       it { is_expected.to redirect_to(root_path) }
-      it { expect(flash[:error]).to eq('Sorry, you are not authorized to delete this Download repository.') }
+      it { expect(flash[:error]).to eq('Sorry, you are not authorized to delete this download repository.') }
       it { expect(DownloadRepository.where(id: dod_repository.id)).to exist }
     end
 
@@ -127,7 +127,7 @@
       end
 
       it { is_expected.to redirect_to(root_path) }
-      it { expect(flash[:error]).to eq('Sorry, you are not authorized to update this Download repository.') }
+      it { expect(flash[:error]).to eq('Sorry, you are not authorized to update this download repository.') }
 
       it 'updates the DownloadRepository' do
         expect(dod_repository.url).to eq('http://suse.com')

src/api/spec/controllers/webui/groups_controller_spec.rb

@@ -61,7 +61,7 @@
       it 'does not allow to create a group' do
         post :create, params: { group: { title: group.title, members: users_to_add.map(&:login).join(',') } }
 
-        expect(flash[:error]).to eq('Sorry, you are not authorized to create this Class.')
+        expect(flash[:error]).to eq('Sorry, you are not authorized to create this group.')
       end
     end
 

src/api/spec/controllers/webui/package_controller_spec.rb

@@ -95,7 +95,7 @@
       it 'does not allow other users than the owner to delete a package' do
         post :remove, params: { project: target_project, package: target_package }
 
-        expect(flash[:error]).to eq('Sorry, you are not authorized to delete this Package.')
+        expect(flash[:error]).to eq('Sorry, you are not authorized to delete this package.')
         expect(target_project.packages).not_to be_empty
       end
 
@@ -258,7 +258,7 @@ def remove_file_post
         remove_file_post
       end
 
-      it { expect(flash[:error]).to eq('Sorry, you are not authorized to update this Package.') }
+      it { expect(flash[:error]).to eq('Sorry, you are not authorized to update this package.') }
       it { expect(Package.where(name: 'my_package')).to exist }
     end
   end
@@ -413,7 +413,7 @@ def remove_file_post
       end
 
       it { expect(a_request(:post, post_url)).not_to have_been_made }
-      it { expect(flash[:error]).to eq('Sorry, you are not authorized to update this Package.') }
+      it { expect(flash[:error]).to eq('Sorry, you are not authorized to update this package.') }
       it { is_expected.to redirect_to(root_path) }
     end
   end
@@ -1103,7 +1103,7 @@ def do_request(params)
         let(:my_user) { create(:confirmed_user, login: 'another_user') }
 
         it { expect(response).to redirect_to(root_path) }
-        it { expect(flash[:error]).to eq('Sorry, you are not authorized to create this Package.') }
+        it { expect(flash[:error]).to eq('Sorry, you are not authorized to create this package.') }
       end
     end
   end

src/api/spec/controllers/webui/packages/branches_controller_spec.rb

@@ -33,7 +33,7 @@
 
     it 'shows an error if user has no permissions for source project' do
       post :create, params: { linked_project: source_project, linked_package: source_package, target_project: 'home:admin:nope' }
-      expect(flash[:error]).to eq('Sorry, you are not authorized to create this Project.')
+      expect(flash[:error]).to eq('Sorry, you are not authorized to create this project.')
       expect(response).to redirect_to(root_path)
     end
 

src/api/spec/controllers/webui/patchinfo_controller_spec.rb

@@ -71,7 +71,7 @@ def do_proper_post_save
       end
 
       it { expect(response).to have_http_status(:redirect) }
-      it { expect(flash[:error]).to eq('Sorry, you are not authorized to update this Project.') }
+      it { expect(flash[:error]).to eq('Sorry, you are not authorized to update this project.') }
     end
 
     context 'when it fails to create the patchinfo package' do

src/api/spec/controllers/webui/projects/project_configuration_controller_spec.rb

@@ -65,7 +65,7 @@
         post :update, params: { project_name: another_project.name, config: 'save config' }
       end
 
-      it { expect(flash[:error]).to eq('Sorry, you are not authorized to update this Project.') }
+      it { expect(flash[:error]).to eq('Sorry, you are not authorized to update this project.') }
       it { expect(response.status).to eq(302) }
       it { expect(response).to redirect_to(root_path) }
     end

src/api/spec/controllers/webui/repositories_controller_spec.rb

@@ -154,7 +154,7 @@
                                        }
         end
 
-        it { expect(response.body).to eq('{"error":"Sorry, you are not authorized to create this Download repository."}') }
+        it { expect(response.body).to eq('{"error":"Sorry, you are not authorized to create this download repository."}') }
       end
     end
 

src/api/spec/controllers/webui/staging/projects_controller_spec.rb

@@ -83,7 +83,7 @@
       end
 
       it { expect(Project.where(name: 'Apache')).not_to exist }
-      it { expect(flash[:error]).to eq('Sorry, you are not authorized to create this Project.') }
+      it { expect(flash[:error]).to eq('Sorry, you are not authorized to create this project.') }
       it { expect(CreateProjectLogEntryJob).not_to have_been_enqueued }
     end
 

src/api/spec/features/webui/attributes_spec.rb

@@ -43,7 +43,7 @@
         click_link('Add Attribute')
         find('select#attrib_attrib_type_id').select('OBS:VeryImportantProject')
         click_button('Add')
-        expect(page).to have_content('Sorry, you are not authorized to create this Attrib.')
+        expect(page).to have_content('Sorry, you are not authorized to create this attrib.')
       end
     end
   end

src/api/spec/features/webui/packages_spec.rb

@@ -369,7 +369,7 @@
         login other_user
         visit new_package_path(project: global_project)
 
-        expect(page).to have_text('Sorry, you are not authorized to create this Package')
+        expect(page).to have_text('Sorry, you are not authorized to create this package')
         expect(page).to have_current_path(root_path, ignore_query: true)
       end
 

src/api/test/functional/request_controller_test.rb

@@ -902,7 +902,7 @@ def test_create_request_with_approver
     post '/request?cmd=create', params: format(req_template, approver: 'fred')
     assert_response 403
     assert_xml_tag(tag: 'status', attributes: { code: 'create_bs_request_not_authorized' })
-    assert_xml_tag(tag: 'summary', content: 'Sorry, you are not authorized to create this Bs request.')
+    assert_xml_tag(tag: 'summary', content: 'Sorry, you are not authorized to create this bs request.')
 
     # request creation succeeds because we are "Iggy"
     post '/request?cmd=create', params: format(req_template, approver: 'Iggy')