Skip to content

Commit

Permalink
[api] OBSEngine::Base#mount_it is not used
Browse files Browse the repository at this point in the history
We never create an instance of `OBSEngine::Base`, so having and
instance method is pointless.

What we actually do is calling the class method with the same name in
all the subclasses. So, the `mount_it` method in `OBSEngine::Base`, but
I guess the idea was to leave the method also in the parent class as
help. In this case, this method should be the class method and not the
instance one.
  • Loading branch information
Ana06 committed Apr 27, 2017
1 parent aebc444 commit 2682de1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/api/lib/engines/base.rb
Expand Up @@ -2,7 +2,7 @@ module OBSEngine
# base class for all engine hooks
class Base
# implement this function to patch the routes
def mount_it
def self.mount_it
end
end

Expand Down

0 comments on commit 2682de1

Please sign in to comment.