Skip to content

Commit

Permalink
Extract staging_project show partial
Browse files Browse the repository at this point in the history
to DRY index and show views.
  • Loading branch information
ChrisBr committed Nov 23, 2018
1 parent 1e2d4f2 commit 29d24a6
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 32 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
builder.staging_project(name: staging_project.name) do
render(partial: 'staged_requests', locals: { staged_requests: staging_project.staged_requests, count: staging_project.staged_requests.count, builder: builder })

render(partial: 'untracked_requests', locals: { untracked_requests: staging_project.untracked_requests, count: staging_project.untracked_requests.count, builder: builder })

render(partial: 'requests_to_review', locals: { requests_to_review: staging_project.requests_to_review, count: staging_project.requests_to_review.count, builder: builder })

render(partial: 'missing_reviews', locals: { missing_reviews: staging_project.missing_reviews, count: staging_project.missing_reviews.count, builder: builder })

render(partial: 'building_repositories', locals: { building_repositories: staging_project.building_repositories, count: staging_project.building_repositories.count, builder: builder })

render(partial: 'broken_packages', locals: { broken_packages: staging_project.broken_packages, count: staging_project.broken_packages.count, builder: builder })
end
20 changes: 1 addition & 19 deletions src/api/app/views/staging/staging_projects/index.xml.builder
Original file line number Diff line number Diff line change
@@ -1,23 +1,5 @@
xml.staging_projects do
@staging_projects.each do |staging_project|
xml.staging_project(name: staging_project.name) do
render(partial: 'staging/staging_projects/staged_requests', locals: { staged_requests: staging_project.staged_requests,
count: staging_project.staged_requests.count, builder: xml })

render(partial: 'staging/staging_projects/untracked_requests', locals: { untracked_requests: staging_project.untracked_requests,
count: staging_project.untracked_requests.count, builder: xml })

render(partial: 'staging/staging_projects/requests_to_review', locals: { requests_to_review: staging_project.requests_to_review,
count: staging_project.requests_to_review.count, builder: xml })

render(partial: 'staging/staging_projects/missing_reviews', locals: { missing_reviews: staging_project.missing_reviews,
count: staging_project.missing_reviews.count, builder: xml })

render(partial: 'staging/staging_projects/building_repositories', locals: { building_repositories: staging_project.building_repositories,
count: staging_project.building_repositories.count, builder: xml })

render(partial: 'staging/staging_projects/broken_packages', locals: { broken_packages: staging_project.broken_packages,
count: staging_project.broken_packages.count, builder: xml })
end
render(partial: 'staging_project_item', locals: { staging_project: staging_project, builder: xml })
end
end
14 changes: 1 addition & 13 deletions src/api/app/views/staging/staging_projects/show.xml.builder
Original file line number Diff line number Diff line change
@@ -1,13 +1 @@
xml.staging_project(name: @staging_project.name) do
render(partial: 'staged_requests', locals: { staged_requests: @staging_project.staged_requests, count: @staging_project.staged_requests.count, builder: xml })

render(partial: 'untracked_requests', locals: { untracked_requests: @staging_project.untracked_requests, count: @staging_project.untracked_requests.count, builder: xml })

render(partial: 'requests_to_review', locals: { requests_to_review: @staging_project.requests_to_review, count: @staging_project.requests_to_review.count, builder: xml })

render(partial: 'missing_reviews', locals: { missing_reviews: @staging_project.missing_reviews, count: @staging_project.missing_reviews.count, builder: xml })

render(partial: 'building_repositories', locals: { building_repositories: @staging_project.building_repositories, count: @staging_project.building_repositories.count, builder: xml })

render(partial: 'broken_packages', locals: { broken_packages: @staging_project.broken_packages, count: @staging_project.broken_packages.count, builder: xml })
end
render(partial: 'staging_project_item', locals: { staging_project: @staging_project, builder: xml })

0 comments on commit 29d24a6

Please sign in to comment.