[webui] Catch missing parameter 'id' in RequestController#show

openSUSE · Apr 13, 2012 · 2b269d4 · 2b269d4
1 parent 402a4b9
commit 2b269d4
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/webui/app/controllers/request_controller.rb b/src/webui/app/controllers/request_controller.rb
@@ -54,8 +54,9 @@ def modify_review
   end
 
   def show
+    redirect_back_or_to :controller => 'home', :action => 'requests' and return if !params[:id]
     begin
-      @req = find_cached(BsRequest, params[:id]) if params[:id]
+      @req = find_cached(BsRequest, params[:id])
     rescue ActiveXML::Transport::Error => e
       flash[:error] = "Can't find request #{params[:id]}"
       redirect_back_or_to :controller => "home", :action => "requests" and return