[api] fix crash on factory reviews

openSUSE · Dec 17, 2012 · 2f8a5e3 · 2f8a5e3
1 parent 8867995
commit 2f8a5e3
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/src/api/app/models/bs_request.rb b/src/api/app/models/bs_request.rb
@@ -607,9 +607,11 @@ def events
     last_review_item = nil
     self.reviews.each do |item|
       if [:accepted, :declined].include?(item.state)
-        ct = events[item.created_at] || { who: item.creator, what: "added review", when: item.created_at }
-        ct[:comment] ||= item.reason
-        events[item.created_at] = ct
+        if item.creator # default reviews in a project are not "added"
+          ct = events[item.created_at] || { who: item.creator, what: "added review", when: item.created_at }
+          ct[:comment] ||= item.reason
+          events[item.created_at] = ct
+        end
 
         events[item.updated_at] = {:who => item.reviewer, :what => "#{item.state} review", :when => item.updated_at, :comment => item.reason}
         events[item.updated_at][:color] = "green" if item.state == :accepted