Skip to content

Commit

Permalink
Prevent scrolling up when pressing 'unresolvable' link
Browse files Browse the repository at this point in the history
We disabled the link by adding '#' as link target. But this was still
causing the scrollbar to move to the top when clicking the link.
  • Loading branch information
bgeuken authored and coolo committed Nov 14, 2018
1 parent 1f1e79d commit 302f88b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/api/app/helpers/webui/buildresult_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ def webui2_arch_repo_table_cell(repo, arch, package_name, status = nil, enable_h
data: { content: Buildresult.status_description(status['code']), placement: 'top', toggle: 'popover' }))
end
if code.in?(['-', 'unresolvable', 'blocked', 'excluded', 'scheduled'])
concat(link_to(code, '#', id: status_id, class: theclass, data: { content: link_title, placement: 'top', toggle: 'popover' }))
concat(link_to(code, 'javascript:void(0);', id: status_id, class: theclass, data: { content: link_title, placement: 'top', toggle: 'popover' }))
else
concat(link_to(code.gsub(/\s/, ' '),
package_live_build_log_path(project: @project.to_s, package: package_name, repository: repo, arch: arch),
Expand Down

0 comments on commit 302f88b

Please sign in to comment.