Update Robocop TODO

src/api/.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config --auto-gen-only-exclude --exclude-limit 100`
-# on 2023-08-04 13:55:21 UTC using RuboCop version 1.55.1.
+# on 2023-09-12 12:41:04 UTC using RuboCop version 1.56.3.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -152,7 +152,7 @@ Lint/UselessMethodDefinition:
     - 'app/controllers/webui/requests/submissions_controller.rb'
     - 'test/test_helper.rb'
 
-# Offense count: 876
+# Offense count: 881
 # Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes.
 Metrics/AbcSize:
   Max: 254
@@ -171,7 +171,7 @@ Metrics/BlockNesting:
     - 'lib/xpath_engine.rb'
     - 'test/node_matcher.rb'
 
-# Offense count: 81
+# Offense count: 82
 # Configuration parameters: CountComments, Max, CountAsOne.
 Metrics/ClassLength:
   Exclude:
@@ -223,7 +223,6 @@ Metrics/ClassLength:
     - 'app/models/staging/workflow.rb'
     - 'app/models/user.rb'
     - 'app/models/user_ldap_strategy.rb'
-    - 'app/models/workflow/step.rb'
     - 'app/models/workflow/step/branch_package_step.rb'
     - 'app/services/user_service/involved.rb'
     - 'db/migrate/20230727110437_migrate_to_utf8mb4.rb'
@@ -259,7 +258,7 @@ Metrics/ClassLength:
     - 'test/unit/publish_flag_test.rb'
     - 'test/unit/user_test.rb'
 
-# Offense count: 192
+# Offense count: 191
 # Configuration parameters: AllowedMethods, AllowedPatterns, Max.
 Metrics/CyclomaticComplexity:
   Exclude:
@@ -350,7 +349,7 @@ Metrics/CyclomaticComplexity:
     - 'test/functional/zzz_post_consistency_test.rb'
     - 'test/node_matcher.rb'
 
-# Offense count: 961
+# Offense count: 963
 # Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
 Metrics/MethodLength:
   Max: 221
@@ -382,7 +381,7 @@ Metrics/ParameterLists:
     - 'test/functional/read_permission_test.rb'
     - 'test/functional/source_controller_test.rb'
 
-# Offense count: 165
+# Offense count: 164
 # Configuration parameters: AllowedMethods, AllowedPatterns, Max.
 Metrics/PerceivedComplexity:
   Exclude:
@@ -657,7 +656,7 @@ Performance/RegexpMatch:
     - 'test/functional/webui/spider_test.rb'
     - 'test/functional/zzz_post_consistency_test.rb'
 
-# Offense count: 21
+# Offense count: 20
 # This cop supports unsafe autocorrection (--autocorrect-all).
 Performance/StringInclude:
   Exclude:
@@ -694,7 +693,7 @@ RSpec/AnyInstance:
     - 'spec/models/project_spec.rb'
     - 'spec/policies/package_policy_spec.rb'
 
-# Offense count: 1222
+# Offense count: 1223
 # Configuration parameters: Prefixes, AllowedPatterns.
 # Prefixes: when, with, without
 RSpec/ContextWording:
@@ -829,7 +828,7 @@ RSpec/IteratedExpectation:
   Exclude:
     - 'spec/models/user_spec.rb'
 
-# Offense count: 374
+# Offense count: 379
 # This cop supports safe autocorrection (--autocorrect).
 RSpec/LeadingSubject:
   Enabled: false
@@ -869,7 +868,7 @@ RSpec/MessageSpies:
     - 'spec/controllers/webui/apidocs_controller_spec.rb'
     - 'spec/models/kiwi/image_spec.rb'
 
-# Offense count: 1670
+# Offense count: 1694
 # Configuration parameters: AllowSubject.
 RSpec/MultipleMemoizedHelpers:
   Max: 28
@@ -997,6 +996,22 @@ Rails/FilePath:
     - 'test/functional/zzz_post_consistency_test.rb'
     - 'test/test_helper.rb'
 
+# Offense count: 9
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: AllowedMethods, AllowedPatterns.
+# AllowedMethods: order, limit, select, lock
+Rails/FindEach:
+  Exclude:
+    - 'app/components/chart_component.rb'
+    - 'app/controllers/public_controller.rb'
+    - 'app/controllers/webui/projects/status_controller.rb'
+    - 'app/helpers/flag_helper.rb'
+    - 'app/policies/token/release_policy.rb'
+    - 'app/views/models/_configuration.xml.builder'
+    - 'db/data/20210707102506_add_api_endpoints_to_payload.rb'
+    - 'db/data/20230620110143_backfill_scm_vendor_and_hook_event_in_workflow_run.rb'
+    - 'spec/factories/bs_requests.rb'
+
 # Offense count: 25
 # Configuration parameters: Include.
 # Include: app/models/**/*.rb
@@ -1209,7 +1224,7 @@ Style/ConditionalAssignment:
   Exclude:
     - 'app/models/bs_request_action_submit.rb'
 
-# Offense count: 992
+# Offense count: 991
 # Configuration parameters: AllowedConstants.
 Style/Documentation:
   Enabled: false
@@ -1221,7 +1236,7 @@ Style/ExplicitBlockArgument:
     - 'app/lib/backend/connection.rb'
     - 'app/models/project.rb'
 
-# Offense count: 1728
+# Offense count: 1730
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: always, always_true, never
@@ -1345,7 +1360,7 @@ Style/SoleNestedConditional:
     - 'script/reformat_memprof'
     - 'test/node_matcher.rb'
 
-# Offense count: 376
+# Offense count: 377
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: MinSize.
 # SupportedStyles: percent, brackets
@@ -1396,7 +1411,7 @@ ViewComponent/MissingPreviewFile:
     - 'app/components/workflow_run_row_component.rb'
     - 'app/components/write_and_preview_component.rb'
 
-# Offense count: 2674
+# Offense count: 2713
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns.
 # URISchemes: http, https