Skip to content

Commit

Permalink
Remove Feature gem and its configuration
Browse files Browse the repository at this point in the history
We decided to move to Flipper gem, it provides all the functionality we
need.
  • Loading branch information
saraycp committed Jul 12, 2019
1 parent 3ee845d commit 3dd9eb3
Show file tree
Hide file tree
Showing 8 changed files with 0 additions and 68 deletions.
1 change: 0 additions & 1 deletion src/api/Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ gem 'mousetrap-rails'
# for issue tracker communication
gem 'xmlrpc'
# Multiple feature switch
gem 'feature'
gem 'flipper'
gem 'flipper-active_record'
# for profiling
Expand Down
2 changes: 0 additions & 2 deletions src/api/Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,6 @@ GEM
railties (>= 4.2.0)
faker (1.9.6)
i18n (>= 0.7)
feature (1.4.0)
ffi (1.11.1)
flipper (0.16.2)
flipper-active_record (0.16.2)
Expand Down Expand Up @@ -495,7 +494,6 @@ DEPENDENCIES
experimental-influxdb-rails (>= 1.0.0.beta5)
factory_bot_rails
faker
feature
flipper
flipper-active_record
flot-rails
Expand Down
7 changes: 0 additions & 7 deletions src/api/app/controllers/application_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -90,13 +90,6 @@ def self.validate_action(opt)

protected

# TODO: remove when all the migration from Feature to Flipper is finished.
# It'll be replaced by feature_enabled?
def feature_active?(feature)
return if Feature.active?(feature)
render file: Rails.root.join('public/404'), status: :not_found, layout: false
end

def validate_params
params.each do |key, value|
next if value.nil?
Expand Down
7 changes: 0 additions & 7 deletions src/api/app/controllers/webui/webui_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -244,13 +244,6 @@ def require_package
end
end

# TODO: remove when all the migration from Feature to Flipper is finished.
# It'll be replaced by feature_enabled?
def feature_active?(feature)
return if Feature.active?(feature)
render file: Rails.root.join('public/404'), status: :not_found, layout: false
end

private

def authenticator
Expand Down
3 changes: 0 additions & 3 deletions src/api/config/initializers/feature.rb

This file was deleted.

17 changes: 0 additions & 17 deletions src/api/lib/feature_switch/feature.rb

This file was deleted.

28 changes: 0 additions & 28 deletions src/api/lib/feature_switch/obs_repository.rb

This file was deleted.

3 changes: 0 additions & 3 deletions src/api/spec/rails_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,6 @@
# helper methods for authentication in models tests
require 'support/models/models_authentication'

# support feature switch testing
require 'feature/testing'

# support Delayed Jobs
require 'support/delayed_job'

Expand Down

0 comments on commit 3dd9eb3

Please sign in to comment.