Skip to content

Commit

Permalink
[webui] Move non-action methods to private section
Browse files Browse the repository at this point in the history
  • Loading branch information
eduardoj committed Jun 4, 2018
1 parent 1f2bf04 commit 468a705
Showing 1 changed file with 11 additions and 11 deletions.
22 changes: 11 additions & 11 deletions src/api/app/controllers/webui/patchinfo_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -220,15 +220,6 @@ def delete_dialog
render_dialog
end

def valid_summary?(name)
name && name.length > 10
end

def valid_description?(name)
name &&
name.length > [params[:summary].length, 50].max
end

def new_tracker
# collection with all informations of the new issues
issue_collection = []
Expand Down Expand Up @@ -274,6 +265,17 @@ def new_tracker
render json: { error: error, issues: issue_collection }
end

private

def valid_summary?(name)
name && name.length > 10
end

def valid_description?(name)
name &&
name.length > [params[:summary].length, 50].max
end

# returns issue summary of an issue
# returns empty string in case of ActiveXML::Transport::Error exception
# returns nil in case of error (bug mismatches tracker result regex)
Expand All @@ -294,8 +296,6 @@ def get_issue_sum(tracker, issueid)
return ''
end

private

def get_binaries
@binarylist = []
binary_list = Buildresult.find(project: params[:project], view: 'binarylist')
Expand Down

0 comments on commit 468a705

Please sign in to comment.