Merge pull request #15836 from hellcp-work/files-url-generation

Verify that the files we try to link to exist

src/api/app/components/sourcediff_tab_component.rb

@@ -17,6 +17,8 @@ def initialize(bs_request:, action:, active:, index:)
 
   def file_view_path(filename, sourcediff)
     return if sourcediff['files'][filename]['state'] == 'deleted'
+    return unless (source_package = Package.find_by_project_and_name(@action[:sprj], @action[:spkg]))
+    return unless source_package.file_exists?(filename, { rev: @action[:srev] }.compact)
 
     diff_params = diff_data(@action[:type], sourcediff)
     diff_params[:project_name] = diff_params[:project]

src/api/app/views/webui/package/rdiff.html.haml

@@ -32,8 +32,11 @@
           - @filenames.each_with_index do |filename, index|
             - revision = calculate_revision_on_state(@rev, @files[filename]['state'])
             .mb-2
+              - file_exists = @package.file_exists?(filename, {rev: revision}.compact)
+              - file_view_path = file_exists ? project_package_file_path(project_name: @project, package_name: @package,
+                                                                         rev: revision, filename: filename) : nil
               = render partial: 'revision_diff_detail',
-              locals: { file_view_path: project_package_file_path(project_name: @project, package_name: @package, rev: revision, filename: filename),
+              locals: { file_view_path: file_view_path,
                 filename: filename,
                 file: @files[filename],
                 index: index,