Skip to content

Commit

Permalink
[dist] Add a environment configuration for our custom migration env
Browse files Browse the repository at this point in the history
This commit links config/environments/migration.rb to config/environments/test.rb.
The migration env is used by a so called migration test we run in our
rpm package builds.

This should solve following error / warning that appear during our
package builds:

[  378s] Created database 'api_25'
[  383s] config.eager_load is set to nil. Please update your config/environments/*.rb files accordingly:
[  383s]
[  383s]   * development - set it to false
[  383s]   * test - set it to false (unless you use a tool that preloads your test environment)
[  383s]   * production - set it to true
[  383s]
  • Loading branch information
bgeuken committed Jun 26, 2017
1 parent 0b99505 commit 47d5380
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/api/config/environments/migration.rb

3 comments on commit 47d5380

@mmohring
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, the .spec file does not package this file, so we get:

[ 1893s] error: Installed (but unpackaged) file(s) found:
[ 1893s] /srv/www/obs/api/config/environments/migration.rb

@hennevogel
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmohring it really doesn't help to report issues as comment to commits. Please open an issue if this is still a problem

@mmohring
Copy link
Contributor

@mmohring mmohring commented on 47d5380 Jul 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know, and reported it otherwise. And problem got fixed. This happened only because this problem got worked on in multiple places. Also I did not know how to request a change. How can I as a normal user without write permission request a change ?

Please sign in to comment.