[api] fix release target filtering on project wide release call

openSUSE · Apr 1, 2014 · 4ea7785 · 4ea7785
1 parent 4c895e1
commit 4ea7785
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/api/app/models/project.rb b/src/api/app/models/project.rb
@@ -1168,9 +1168,9 @@ def my_not_equal(a, b)
       next if pkg.name == "_product" # will be handled via _product:*
       pkg.project.repositories.each do |repo|
         next if my_not_equal(params[:repository], repo.name)
-        next if my_not_equal(params[:targetproject], repo.releasetarget.project)
-        next if my_not_equal(params[:targetreposiory], repo.releasetarget.repository)
         repo.release_targets.each do |releasetarget|
+          next if my_not_equal(params[:targetproject], releasetarget.target_repository.project.name)
+          next if my_not_equal(params[:targetreposiory], releasetarget.target_repository.name)
           # release source and binaries
           # permission checking happens inside this function
           release_package(pkg, releasetarget.target_repository.project.name, pkg.name, repo, nil, params[:setrelease], true)

diff --git a/src/api/test/unit/code_quality_test.rb b/src/api/test/unit/code_quality_test.rb
@@ -111,6 +111,7 @@ def setup
       'Package#revoke_requests' => 51.82,
       'PersonController#internal_register' => 108.84,
       'PersonController#put_userinfo' => 56.38,
+      'Project#do_project_release' => 50.51,
       'Project#release_targets_ng' => 57.91,
       'Project#update_download_settings' => 52.3, 
       'Project#update_from_xml' => 68.71,