Merge pull request #12331 from saraycp/rename_methods_relationship_ev…

…ents

Rename methods to create/delete relationship events

src/api/app/mixins/has_relationships.rb

@@ -55,7 +55,7 @@ def remove_role(what, role)
           end
     rel = rel.where(role_id: role.id) if role
     transaction do
-      rel.map(&:create_event_before_delete)
+      rel.map(&:create_relationship_delete_event)
       rel.delete_all
       write_to_backend
     end

src/api/app/models/relationship.rb

@@ -60,7 +60,7 @@ class Relationship < ApplicationRecord
     bugowners.joins(:user).merge(User.with_email)
   }
 
-  after_create :create_event_after_create
+  after_create :create_relationship_create_event
 
   # we only care for project<->user relationships, but the cache is not *that* expensive
   # to recalculate
@@ -127,7 +127,7 @@ def self.with_groups_and_roles
     with_groups_and_roles_query.pluck('groups.title', 'roles.title')
   end
 
-  def create_event_before_delete
+  def create_relationship_delete_event
     return unless User.session
 
     Event::RelationshipDelete.create(event_parameters)
@@ -167,7 +167,7 @@ def allowed_user
     raise NotFoundError, "Couldn't find user #{user.login}" if user && user.is_nobody?
   end
 
-  def create_event_after_create
+  def create_relationship_create_event
     return unless User.session
 
     Event::RelationshipCreate.create(event_parameters)