[api] brakeman dislikes a fixed secret_key_base

So move it into test/development environments to avoid the (false) warning
openSUSE · Nov 3, 2013 · 62c6073 · 62c6073
1 parent 2734b81
commit 62c6073
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/src/api/config/environments/development.rb b/src/api/config/environments/development.rb
@@ -38,6 +38,8 @@
   config.eager_load = false
 
   config.allow_concurrency = false
+
+  config.secret_key_base = '92b2ed725cb4d68cc5fbf86d6ba204f1dec4172086ee7eac8f083fb62ef34057f1b770e0722ade7b298837be7399c6152938627e7d15aca5fcda7a4faef91fc7'
 end
 
 CONFIG['extended_backend_log'] = true

diff --git a/src/api/config/environments/test.rb b/src/api/config/environments/test.rb
@@ -32,6 +32,8 @@
 
   # better test with compressed
   config.assets.js_compressor = :uglifier
+
+  config.secret_key_base = '92b2ed725cb4d68cc5fbf86d6ba204f1dec4172086ee7eac8f083fb62ef34057f1b770e0722ade7b298837be7399c6152938627e7d15aca5fcda7a4faef91fc7'
 end
 
 CONFIG['source_host'] = "localhost"

diff --git a/src/api/config/initializers/secret_token.rb b/src/api/config/initializers/secret_token.rb
@@ -10,7 +10,4 @@
   OBSApi::Application.config.secret_key_base = File.read "#{Rails.root}/config/secret.key"
 elsif Rails.env.production?
   raise "Missing config/secret.key file!"
-else
-  # for development and test environment
-  OBSApi::Application.config.secret_key_base = '92b2ed725cb4d68cc5fbf86d6ba204f1dec4172086ee7eac8f083fb62ef34057f1b770e0722ade7b298837be7399c6152938627e7d15aca5fcda7a4faef91fc7'
 end