Merge pull request #4180 from mschnitzer/refactor_type_to_class_handl…

…ing_in_bs_request_model [webui] Get rid of hardcoded string to class mapping
openSUSE · Dec 4, 2017 · 633971a · 633971a
2 parents 0d63239 + 38faed0
commit 633971a
Showing 1 changed file with 1 addition and 18 deletions.
diff --git a/src/api/app/models/bs_request_action.rb b/src/api/app/models/bs_request_action.rb
@@ -74,24 +74,7 @@ def self.get_package_diff(path, query)
   end
 
   def self.type_to_class_name(type_name)
-    case type_name
-    when :submit then
-      BsRequestActionSubmit
-    when :delete then
-      BsRequestActionDelete
-    when :change_devel then
-      BsRequestActionChangeDevel
-    when :add_role then
-      BsRequestActionAddRole
-    when :set_bugowner then
-      BsRequestActionSetBugowner
-    when :maintenance_incident then
-      BsRequestActionMaintenanceIncident
-    when :maintenance_release then
-      BsRequestActionMaintenanceRelease
-    when :group then
-      BsRequestActionGroup
-    end
+    "bs_request_action_#{type_name}".classify.constantize
   end
 
   def self.find_sti_class(type_name)