Simplify updating request attributes

openSUSE · Feb 18, 2019 · 64a871a · 64a871a
1 parent 5e4f84e
commit 64a871a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 12 deletions.
diff --git a/src/api/spec/bootstrap/features/webui/requests_spec.rb b/src/api/spec/bootstrap/features/webui/requests_spec.rb
@@ -204,13 +204,11 @@
 
   describe 'shows the correct auto accepted message' do
     before do
-      bs_request.accept_at = Time.now
-      bs_request.save
+      bs_request.update_attributes(accept_at: Time.now)
     end
 
     scenario 'when request is in a final state' do
-      bs_request.state = :accepted
-      bs_request.save
+      bs_request.update_attributes(state: :accepted)
       visit request_show_path(bs_request)
       expect(page).to have_text("Auto-accept was set to #{I18n.localize bs_request.accept_at, format: :only_date}.")
     end
@@ -221,8 +219,7 @@
     end
 
     scenario 'when request auto_accept is in the future and not in a final state' do
-      bs_request.accept_at = Time.now + 1.day
-      bs_request.save
+      bs_request.update_attributes(accept_at: Time.now + 1.day)
       visit request_show_path(bs_request)
       expect(page).
         to have_text("This request will be automatically accepted in #{ApplicationController.helpers.time_ago_in_words(bs_request.accept_at)}.")

diff --git a/src/api/spec/features/webui/requests_spec.rb b/src/api/spec/features/webui/requests_spec.rb
@@ -192,13 +192,11 @@
 
   describe 'shows the correct auto accepted message' do
     before do
-      bs_request.accept_at = Time.now
-      bs_request.save
+      bs_request.update_attributes(accept_at: Time.now)
     end
 
     scenario 'when request is in a final state' do
-      bs_request.state = :accepted
-      bs_request.save
+      bs_request.update_attributes(state: :accepted)
       visit request_show_path(bs_request)
       expect(page).to have_text("Auto-accept was set to #{I18n.localize bs_request.accept_at, format: :only_date}.")
     end
@@ -209,8 +207,7 @@
     end
 
     scenario 'when request auto_accept is in the future and not in a final state' do
-      bs_request.accept_at = Time.now + 1.day
-      bs_request.save
+      bs_request.update_attributes(accept_at: Time.now + 1.day)
       visit request_show_path(bs_request)
       expect(page).
         to have_text("This request will be automatically accepted in #{ApplicationController.helpers.time_ago_in_words(bs_request.accept_at)}.")